Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): Fix a regressions of changing TabGroup's title after it was created. (8_0_X) #10779

Merged
merged 5 commits into from Mar 25, 2019
Merged

fix(android): Fix a regressions of changing TabGroup's title after it was created. (8_0_X) #10779

merged 5 commits into from Mar 25, 2019

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Mar 14, 2019

@ypbnv ypbnv added this to the 8.0.1 milestone Mar 14, 2019
@ypbnv ypbnv requested a review from garymathews March 14, 2019 15:51
@build build requested a review from a team March 14, 2019 16:23
@build
Copy link
Contributor

build commented Mar 14, 2019 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ❌ 1 tests have failed There are 1 tests failing and 450 skipped out of 3018 total tests.

Tests:

Classname Name Time Error
android.emulator.Titanium.UI.WebView .zoomLevel 10.002 timeout of 10000ms exceeded

Generated by 🚫 dangerJS against 8075f2a

jquick-axway
jquick-axway approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssjsamir ssjsamir self-requested a review March 22, 2019 15:51
ssjsamir
ssjsamir approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: When a Window has its own title in a tabGroup the title now appears.

Test Environment

Google pixel xl 7.1.1 sim
APPC CLI: 7.0.10
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

@sgtcoolguy sgtcoolguy merged commit 5b3743c into tidev:8_0_X Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssjsamir ssjsamir ssjsamir approved these changes

@jquick-axway jquick-axway jquick-axway approved these changes

@garymathews garymathews Awaiting requested review from garymathews

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ypbnv @build @ssjsamir @jquick-axway @sgtcoolguy