fix(android): Fix a regressions of changing TabGroup's title after it was created. (8_0_X)

android/modules/ui/src/java/ti/modules/titanium/ui/TabGroupProxy.java

@@ -35,6 +35,7 @@
 import android.os.Build;
 import android.os.Message;
 import android.os.Bundle;
+import android.support.v7.app.ActionBar;
 import android.support.v7.app.AppCompatActivity;
 
 // clang-format off
@@ -65,6 +66,7 @@ public class TabGroupProxy extends TiWindowProxy implements TiActivityWindow
 	private ArrayList<TabProxy> tabs = new ArrayList<TabProxy>();
 	private WeakReference<AppCompatActivity> tabGroupActivity;
 	private TabProxy selectedTab;
+	private String tabGroupTitle = null;
 	private boolean isFocused;
 
 	public TabGroupProxy()
@@ -348,6 +350,36 @@ public TabProxy getActiveTab()
 		}
 	}
 
+	@Kroll.getProperty
+	public String getTitle()
+	{
+		// If the native view is drawn get the title value from the SupportActionBar
+		if (view != null) {
+			if (getActivity() != null) {
+				ActionBar actionBar = ((AppCompatActivity) getActivity()).getSupportActionBar();
+				if (actionBar != null) {
+					return actionBar.getTitle().toString();
+				}
+			}
+			return null;
+		} else {
+			// If the native view is not drawn return tha latest String saved as a title
+			return tabGroupTitle;
+		}
+	}
+
+	@Kroll.setProperty
+	public void setTitle(String title)
+	{
+		// If the native view is drawn directly set the String as a title for the SupportActionBar.
+		if (view != null) {
+			((TiUIAbstractTabGroup) view).updateTitle(title);
+		} else {
+			// If the native view is not yet drawn save the value to be passed during creation.
+			this.tabGroupTitle = title;
+		}
+	}
+
 	private TabProxy handleGetActiveTab()
 	{
 		//selectedTab may not be set when user queries activeTab, so we return
@@ -411,7 +443,10 @@ public void windowCreated(TiBaseActivity activity, Bundle savedInstanceState)
 		} else {
 			view = new TiUIBottomNavigationTabGroup(this, activity);
 		}
-
+		// If we have set a title before the creation of the native view, set it now.
+		if (this.tabGroupTitle != null) {
+			((TiUIAbstractTabGroup) view).updateTitle(this.tabGroupTitle);
+		}
 		setModelListener(view);
 
 		handlePostOpen();

android/modules/ui/src/java/ti/modules/titanium/ui/widget/tabgroup/TiUIAbstractTabGroup.java

@@ -20,6 +20,7 @@
 import android.support.v4.app.FragmentPagerAdapter;
 import android.support.v4.view.PagerAdapter;
 import android.support.v4.view.ViewPager;
+import android.support.v7.app.ActionBar;
 import android.support.v7.app.AppCompatActivity;
 import android.util.TypedValue;
 import android.view.LayoutInflater;
@@ -386,6 +387,16 @@ public TabProxy getSelectedTab()
 		return ((TabGroupProxy) getProxy()).getTabList().get(this.tabGroupViewPager.getCurrentItem());
 	}
 
+	public void updateTitle(String title)
+	{
+		// Get a reference to the ActionBar
+		ActionBar actionBar = ((AppCompatActivity) proxy.getActivity()).getSupportActionBar();
+		// Guard for trying to update the ActionBar's title when a theme without one is used.
+		if (actionBar != null) {
+			actionBar.setTitle(title);
+		}
+	}
+
 	/**
 	 * Implemenation of the FragmentPagerAdapter
 	 */

tests/Resources/ti.ui.tabgroup.addontest.js

@@ -0,0 +1,32 @@
+/*
+ * Appcelerator Titanium Mobile
+ * Copyright (c) 2011-Present by Appcelerator, Inc. All Rights Reserved.
+ * Licensed under the terms of the Apache Public License
+ * Please see the LICENSE included with this distribution for details.
+ */
+/* eslint-env mocha */
+/* global Ti */
+/* eslint no-unused-expressions: "off" */
+'use strict';
+const should = require('./utilities/assertions'); // eslint-disable-line no-unused-vars
+
+// skipping many test on Windows due to lack of event firing, see https://jira.appcelerator.org/browse/TIMOB-26690
+describe('Titanium.UI.TabGroup', () => {
+
+	it('title after drawing the TabGroup', () => {
+		var winA = Ti.UI.createWindow(),
+			winB = Ti.UI.createWindow(),
+			tabA = Ti.UI.createTab({ title: 'titleA', window: winA }),
+			tabB = Ti.UI.createTab({ title: 'titleB', window: winB }),
+			tabGroup = Ti.UI.createTabGroup({ tabs: [ tabA, tabB ] });
+		tabGroup.addEventListener('open', () => {
+			tabGroup.title = 'newTitle';
+			tabGroup.setActiveTab(tabB);
+		});
+		tabB.addEventListener('selected', () => {
+			should(tabGroup.title).be.a.String;
+			should(tabGroup.title).eql('newTitle');
+		});
+	});
+
+});