Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios)(8_0_X): Supported tel protocol similar to previous implementation #10794

Merged
merged 8 commits into from Apr 3, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build
Copy link
Contributor

build commented Mar 21, 2019

Messages
📖

✅ All tests are passing
Nice one! All 1587 tests are passing.

Generated by 🚫 dangerJS against 7c8d045

@sgtcoolguy
Copy link
Contributor

This should ideally have at least one unit test defined to confirm the fix/feature.

Is the use case trying to "open" a tel: style url to dial a phone number? Is the issue that it actually would exit out app with no way to return if you invoked it?

Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the log message to explain that this a iOS only recommendation.

@janvennemann
Copy link
Contributor

@sgtcoolguy, to goal is that tel: style links will be properly handled and a user is able to dial the number. Currently is doing nothing and just ignoring the link click.

I 'm not sure this can be tested with a unit test since it requires user interaction. Or can we emulate user clicks in a unit test in our suite? cc @vijaysingh-axway to confirm.

@ssjsamir ssjsamir self-requested a review April 3, 2019 10:17
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to get call pop menu from a webView

Test Environment

iPhone 6 (12.1)
APPC CLI: 7.0.10
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

@sgtcoolguy sgtcoolguy merged commit 5fd79ba into tidev:8_0_X Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants