-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios)(8_0_X): Supported tel protocol similar to previous implementation #10794
Conversation
This should ideally have at least one unit test defined to confirm the fix/feature. Is the use case trying to "open" a tel: style url to dial a phone number? Is the issue that it actually would exit out app with no way to return if you invoked it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the log message to explain that this a iOS only recommendation.
@sgtcoolguy, to goal is that I 'm not sure this can be tested with a unit test since it requires user interaction. Or can we emulate user clicks in a unit test in our suite? cc @vijaysingh-axway to confirm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed: Able to get call pop menu from a webView
Test Environment
iPhone 6 (12.1)
APPC CLI: 7.0.10
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1
https://jira.appcelerator.org/browse/TIMOB-26835