You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request adds full Swift 5 compatibility, in summary:
Update iOS example Swift module to Swift 5
Update iOS Swift module template to Swift 5
Resolve all project warnings (including missing method selectors, nullability flags and strict prototypes). Not removing the deprecations for now, which should be done in a separate ticket
Tested and confirmed to work. Common steps:
Create a new app and build it
Create a new iOS Swift module and build + import it
Open the Titanium Xcode project template under iphone/iphone/Titanium.xcodeproj and build it
🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖
> titanium-mobile@8.1.0 test /Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-10830
> npm run ios-sanity-check && grunt
> titanium-mobile@8.1.0 ios-sanity-check /Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-10830
> ./build/scons check-ios-toplevel
Running "appcJs:src:lintOnly" (appcJs) task
Running "eslint:src" (eslint) task
/Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-10830/iphone/cli/commands/_build.js
6410:79 warning 'out' is defined but never used no-unused-vars
/Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-10830/iphone/cli/hooks/frameworks.js
61:5 warning Expected catch() or return promise/catch-or-return
61:34 warning Avoid calling back inside of a promise promise/no-callback-in-promise
428:5 warning Each then() should return a value or throw promise/always-return
✖ 4 problems (0 errors, 4 warnings)
Running "checkFormat:ios" (checkFormat) task
Fatal error: Error: Formatting incorrect on "iphone/TitaniumKit/TitaniumKit/Sources/Kroll/KrollTimerManager.h", proposed changes: <?xml version='1.0'?>
<replacements xml:space='preserve' incomplete_format='false'>
<replacement offset='1153' length='1'></replacement>
</replacements>
�
npm ERR! Test failed. See above for more details.
🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖
✅ All tests are passing
Nice one! All 4380 tests are passing.
(There are 472 tests skipped)
📖
🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
I would like to split this PR up into the Swift version upgrade and fixing the warning messages. For the Swift version upgrade i created #10974. The warnings will be addressed via TIMOB-27163 by using the remaining changes of this PR.
@lokeshchdhry resolved the first merge conflicts. Please do the FR on #10974 first. Merging that will create new conflicts in this PR that i'll resolve again and then you can do the FR on this one.
FR Passed. warning reduced.
Test Environment:
Name = Mac OS X
Version = 10.14.5
Architecture = 64bit
Node.js
Node.js Version = 10.16.2
npm Version = 6.9.0
Titanium CLI
CLI Version = 5.2.1
Titanium SDK
SDK Version = local sdk 8.2.0.v20190902191234
Device -iPhone X iOS 11,iphone xr iOS 13
Simulator -iPhone 8 iOS 12.4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-27163
This pull request
adds full Swift 5 compatibility, in summary:Update iOS example Swift module to Swift 5Update iOS Swift module template to Swift 5Tested and confirmed to work. Common steps:
Create a new app and build itCreate a new iOS Swift module and build + import itiphone/iphone/Titanium.xcodeproj
and build it