You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional Description:
Cherry-picked commit from #10830 to only update the module template to Swift 5 and apply recommended project settings from Xcode 10.2.
The reason will be displayed to describe this comment to others. Learn more.
⚠️ iphone/templates/module/swift/template/ios/hooks/ti.swiftsupport.js line 22 – 'appc' is defined but never used. Allowed unused args must match /^_.+/. (no-unused-vars)
✅ All tests are passing
Nice one! All 3619 tests are passing.
(There are 464 tests skipped)
📖
🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
FR Passed. No error on building module using swift 5 with the fix.
Operating System
Name = Mac OS X
Version = 10.14.5
Architecture = 64bit
Node.js
Node.js Version = 10.13.0
npm Version = 6.4.1
Titanium CLI
CLI Version = 5.1.1
Titanium SDK
SDK Version = local sdk 8.2.0.v20190624064632
cli -7.0.12
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26770
Optional Description:
Cherry-picked commit from #10830 to only update the module template to Swift 5 and apply recommended project settings from Xcode 10.2.