New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-26963] Remove fields added to iOS required modules #10929
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be a leftover of our old require implementation which, for some reason, assumed that every module needs to export an url
and id
property. I guess it's safe to be removed.
cc @sgtcoolguy to confirm since he did the rework on the require implementation
Ha I left this around because I had no idea how/if it was used. But hey, the tests all pass and the world didn't end. I'm fine with merging this for 8.2.1... |
@sgtcoolguy - Is it possible this could get merged into 8.2.0? |
I believe this PR will fix this issue as well: https://jira.appcelerator.org/browse/TIMOB-20487 |
@brentonhouse It's too late to add this to 8.2.0. It'll have to go into 8.2.1. |
FR Passed. Appropriate fields available for the required common js module. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-26963
These fields are being injected into iOS modules (in the case of the ticket, a JSON file). These fields seem redundant, so I just removed them. I assume Jenkins will break if they're necessary somehow :) I couldn't find them anywhere else at a glance.