Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26963] Remove fields added to iOS required modules #10929

Merged
merged 5 commits into from
Sep 25, 2019
Merged

[TIMOB-26963] Remove fields added to iOS required modules #10929

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4150bdd
Remove fields added to iOS required modules
whitfin May 31, 2019
5b1887f
Merge branch 'master' into TIMOB-26963
whitfin Jun 4, 2019
e520960
Merge branch 'master' into TIMOB-26963
whitfin Jun 19, 2019
5ee1637
Merge branch 'master' into TIMOB-26963
Sep 23, 2019
88099ff
Merge branch 'master' into TIMOB-26963
lokeshchdhry Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions iphone/TitaniumKit/TitaniumKit/Sources/API/KrollBridge.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,12 +871,6 @@ - (KrollWrapper *)loadJavascriptText:(NSString *)data fromFile:(NSString *)filen
userInfo:nil];
}

if (filename != nil && module != nil) {
// uri is optional but we point it to where we loaded it
[module replaceValue:[NSString stringWithFormat:@"app://%@", filename] forKey:@"uri" notification:NO];
[module replaceValue:filename forKey:@"id" notification:NO]; // set id to full path, originally this was the path from require call
}

return module;
}

Expand Down