New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update Swift module template to Swift 5 (8_1_X) #10977
Conversation
* @param {Object} logger The logger instance. | ||
* @param {Object} config The hook config. | ||
* @param {Object}cli The Titanium CLI instance. | ||
* @param {Object} appc The Appcelerator CLI instance. | ||
*/ | ||
function init(logger, config, cli, appc) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ iphone/templates/module/swift/template/ios/hooks/ti.swiftsupport.js line 22 – 'appc' is defined but never used. Allowed unused args must match /^_.+/. (no-unused-vars)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR passed.
FR Passed. No error on building module using swift 5 with the fix. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-26770
8_1_X backport of #10974