chore(ios): prevent modal windows from being swiped down #11057

vijaysingh-axway · 2019-07-17T23:26:01Z

https://jira.appcelerator.org/browse/TIMOB-27169

build · 2019-07-17T23:44:05Z

	Fails
🚫	Tests have failed, see below for more information.

	Warnings
⚠️	Commit 6d31046257196aa751ed98a0f728606d6dae60ab has a message "chore(ios) : Added support for Xcode 11 / iOS 13 dev environment" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit e5bd9fc9dd2a72dae983bde75502d892f80ab92f has a message "feat(iOS): Removed IS_XCODE_9 constants from code" giving 2 errors: scope must be lower-case subject must not be sentence-case, start-case, pascal-case, upper-case
⚠️	Commit 5ea4b6b32c3175ac45bb40e04e0614163bed8ac7 has a message "feat(android): Optimized TextField/TextArea handling in TableView (#10745) [TIMOB-26862] Android: Modified TextField/TextArea to not flicker or log warnings when changing "text" property while keyboard is shown Revert "[TIMOB-26862] Android: Modified TextField/TextArea to not flicker or log warnings when changing "text" property while keyboard is shown" This reverts commit `1d8eb8c`. [TIMOB-26862] Android: Modified TableView to better handle rows containing TextFields/TextAreas All rows now keep their existing parent row container view. We don't want to re-parent an EditText parent. Causes havoc with virtual keyboard. Simplified TableView getView() recycling code." giving 2 errors: header must not be longer than 72 characters, current length is 74 subject must not be sentence-case, start-case, pascal-case, upper-case

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	❌ 1 tests have failed There are 1 tests failing and 472 skipped out of 4367 total tests.
📖	🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Tests:

Classname

Name

Time

Error

ios.os

#hostname() returns Ti.Platform.address value

0

Error: expected '' to equal undefined
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/39DACA38-9CF4-4866-8FAA-76428DF4192A/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/39DACA38-9CF4-4866-8FAA-76428DF4192A/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/39DACA38-9CF4-4866-8FAA-76428DF4192A/mocha.app/os.test.js:123:31
file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/39DACA38-9CF4-4866-8FAA-76428DF4192A/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/39DACA38-9CF4-4866-8FAA-76428DF4192A/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/39DACA38-9CF4-4866-8FAA-76428DF4192A/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/39DACA38-9CF4-4866-8FAA-76428DF4192A/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/39DACA38-9CF4-4866-8FAA-76428DF4192A/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/39DACA38-9CF4-4866-8FAA-76428DF4192A/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/39DACA38-9CF4-4866-8FAA-76428DF4192A/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/A4D657E1-8DBA-4260-B8D2-C42E1A9F52AB/data/Containers/Bundle/Application/39DACA38-9CF4-4866-8FAA-76428DF4192A/mocha.app/ti-mocha.js:5764:29

Generated by 🚫 dangerJS against 60232ed

iphone/TitaniumKit/TitaniumKit/Sources/API/TiWindowProxy.m

…dev#10745) * [TIMOB-26862] Android: Modified TextField/TextArea to not flicker or log warnings when changing "text" property while keyboard is shown * Revert "[TIMOB-26862] Android: Modified TextField/TextArea to not flicker or log warnings when changing "text" property while keyboard is shown" This reverts commit 1d8eb8c. * [TIMOB-26862] Android: Modified TableView to better handle rows containing TextFields/TextAreas - All rows now keep their existing parent row container view. - We don't want to re-parent an EditText parent. Causes havoc with virtual keyboard. - Simplified TableView getView() recycling code.

iphone/TitaniumKit/TitaniumKit/Sources/API/TiWindowProxy.m

hansemannn · 2019-08-21T20:07:05Z

@vijaysingh-axway Can you squash the commits please? Otherwise it's hard to cherry pick

vijaysingh-axway · 2019-08-27T20:57:23Z

@janvennemann Can you review it please?

janvennemann · 2019-08-28T08:24:17Z

iphone/TitaniumKit/TitaniumKit/Sources/API/TiWindowProxy.m

@@ -46,6 +46,7 @@ - (void)_destroy

 - (void)_configure
 {
+  forceModal = YES;


Why is this set to YES here when it's default value is defined as NO?

For iOS 12, by default it is true. So it is set 'YES' in configuration. For iOS 13, it'll take its value from property. Inside

(void)viewDidDisappear:(BOOL)animated
{
if (isModal && closing) {
if (isModal && (closing || !forceModal)) {
[self windowDidClose];
}
}
we are checking this property for firing close event in iOS 13, which should not affect iOS 12 behaviour. So set it YES.
This has been already tested by Hans and Donovan.

Ah, I was just wondering what's the reason behind that. Thanks for the explanation.

ssjsamir

FR Passed Modal windows no longer being swiped down. Tested with the two test case from https://jira.appcelerator.org/browse/TIMOB-27169

Test Environment

MacOS Mojave version 10.14.4
Xcode 11 beta 5
Node.js ^8.11.1
iPhone 8 sim (13.0)
"NPM":"4.2.14","CLI":"7.1.1-master.2"

vijaysingh-axway added 7 commits June 4, 2019 14:01

chore(ios) : Added support for Xcode 11 / iOS 13 dev environment

6d31046

Merge branch 'master' into TIMOB-27125

749c396

Merge branch 'master' into TIMOB-27125

877accd

feat(iOS): Removed IS_XCODE_9 constants from code

e5bd9fc

Merge branch 'master' into TIMOB-27125

1484cad

Merge branch 'master' into TIMOB-27125

719c9f9

chore(ios): prevent modal windows from being swiped down

b326074

build added this to the 8.2.0 milestone Jul 17, 2019

build requested review from a team July 17, 2019 23:44

build added docs ios needs tests 🚨 labels Jul 17, 2019

hansemannn reviewed Jul 18, 2019

View reviewed changes

iphone/TitaniumKit/TitaniumKit/Sources/API/TiWindowProxy.m Outdated Show resolved Hide resolved

jquick-axway and others added 8 commits July 18, 2019 15:46

feat(ios): updated constants

badda41

test(db): bump up timeouts

0415939

test(db): drop long-running query count to 5000 rows

c734de8

test(db): bump up timeout

50121c3

test: migrate overridden tests to suite

f40d639

Merge branch 'master' into TIMOB-27169

a8c8922

Merge branch 'master' into TIMOB-27169

b2fddd0

vijaysingh-axway added no tests and removed needs tests 🚨 labels Jul 22, 2019

janvennemann requested changes Jul 23, 2019

View reviewed changes

iphone/TitaniumKit/TitaniumKit/Sources/API/TiWindowProxy.m Outdated Show resolved Hide resolved

janvennemann reviewed Jul 23, 2019

View reviewed changes

iphone/TitaniumKit/TitaniumKit/Sources/API/TiWindowProxy.m Show resolved Hide resolved

vijaysingh-axway mentioned this pull request Aug 13, 2019

fix(ios): properly fire close event for iOS 13+ modal windows #11135

Closed

vijaysingh-axway added 2 commits August 16, 2019 16:06

chore(ios): prevent modal windows from being swiped down

5cc3bd1

Merge branch 'master' into TIMOB-27169

0a98b0e

Merge branch 'master' into TIMOB-27169

2587c2c

Merge branch 'master' into TIMOB-27169

9974ced

janvennemann reviewed Aug 28, 2019

View reviewed changes

janvennemann approved these changes Aug 28, 2019

View reviewed changes

ssjsamir self-requested a review August 29, 2019 14:12

ssjsamir approved these changes Aug 29, 2019

View reviewed changes

Merge branch 'master' into TIMOB-27169

60232ed

sgtcoolguy merged commit 118bf47 into tidev:master Aug 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ios): prevent modal windows from being swiped down #11057

chore(ios): prevent modal windows from being swiped down #11057

vijaysingh-axway commented Jul 17, 2019

build commented Jul 17, 2019 •

edited

hansemannn commented Aug 21, 2019

vijaysingh-axway commented Aug 27, 2019

janvennemann Aug 28, 2019

vijaysingh-axway Aug 28, 2019

janvennemann Aug 28, 2019

ssjsamir left a comment

chore(ios): prevent modal windows from being swiped down #11057

chore(ios): prevent modal windows from being swiped down #11057

Conversation

vijaysingh-axway commented Jul 17, 2019

build commented Jul 17, 2019 • edited

Tests:

hansemannn commented Aug 21, 2019

vijaysingh-axway commented Aug 27, 2019

janvennemann Aug 28, 2019

Choose a reason for hiding this comment

vijaysingh-axway Aug 28, 2019

Choose a reason for hiding this comment

janvennemann Aug 28, 2019

Choose a reason for hiding this comment

ssjsamir left a comment

Choose a reason for hiding this comment

build commented Jul 17, 2019 •

edited