fix(ios): properly fire close event for iOS 13+ modal windows

[hansemannn]

JIRA: https://jira.appcelerator.org/browse/TIMOB-27332

[build]

	Fails
🚫	🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
🚫	Test suite crashed on iOS simulator. Please see the crash log for more details.

	Warnings
⚠️	🔍 Can't find junit reports at ./junit.*.xml, skipping generating JUnit Report.

	Messages
📖	🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 7b04719

[hansemannn]

It seems like this crashes with the test suite but I cannot access the logs. I thought that no Xcode 11 guards are required since it's only a new delegate function which part of an existing delegate and won't be called on earlier versions, but it may does cause issues!

[vijaysingh-axway]

@hansemannn It is crashing when opening and closing window multiple times. See PR #11057. In this PR, this issue is already fixed.

[hansemannn]

@vijaysingh-axway Is that really the same thing? Your PR is for configuring whether or not a modal window should be swipeable, this one is a bugfix for windows that don't trigger a close event, causing huge glitches in depending apps. I see you introduced a new flag for it, so if it works for this one as well, feel free to cherry-pick and integrate my changes into your PR.

[vijaysingh-axway]

@vijaysingh-axway Is that really the same thing? Your PR is for configuring whether or not a modal window should be swipeable, this one is a bugfix for windows that don't trigger a close event, causing huge glitches in depending apps. I see you introduced a new flag for it, so if it works for this one as well, feel free to cherry-pick and integrate my changes into your PR.

@hansemannn What I mean was, In my PR #11057, 'close' event handling for iOS 13+ modal windows is already there . I have verified your test case. So we do not need this PR. It would be great, if you can test at your end. Thanks!

[hansemannn]

Not required anymore.