Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(8_1_X): Resuming with intent "FLAG_ACTIVITY_MULTIPLE_TASK" can hang the app #11081

Merged
merged 3 commits into from Aug 20, 2019

Conversation

jquick-axway
Copy link
Contributor

…hang the app

- Modified to effectively restart the app when the following intent flags are set:
  * FLAG_ACTIVITY_MULTIPLE_TASK
  * FLAG_ACTIVITY_NEW_DOCUMENT
- Modified resume code to use main/launch intent flags.
  * We don't want flags such as FLAG_ACTIVITY_CLEAR_TOP to destroy child activities when resuming app.
@build build requested a review from a team July 26, 2019 02:56
@build
Copy link
Contributor

build commented Jul 26, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ❌ 1 tests have failed There are 1 tests failing and 226 skipped out of 1930 total tests.

Tests:

ClassnameNameTimeError
ios.Titanium.UI.WebViewuserAgent29.999
Error: timeout of 30000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/6DE1A7F7-2788-4FA8-811F-AC29E0B941E8/data/Containers/Bundle/Application/1EC7EAA6-9BE3-4ADA-BCCB-DFF270E0094E/mocha.app/ti-mocha.js:4326:27

Generated by 🚫 dangerJS against e69421a

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@keerthi1032
Copy link
Contributor

FR Passed. NO hanging when resuming app app with an intent having FLAG_ACTIVITY_MULTIPLE_TASK. Works as Expected. Waiting for the 8.1.0 GA release to merge this PR

Test Environment:
Operating System
Name = Mac OS X
Version = 10.14.5
Architecture = 64bit
Node.js
Node.js Version = 10.16.0
npm Version = 6.9.0
Titanium CLI
CLI Version = 5.2.1
Titanium SDK
SDK Version =local sdk 8.1.0.v20190725194646 and 8.2.0.v20190729101453
Device -Samsung s5 android 6, Oneplus 5T android 9
Emulator - pixel android 9

@keerthi1032
Copy link
Contributor

iOS unit tests failed. Not able to merge PR. @jquick-axway can you please resolve the Jenkins failure and merge PR

@sgtcoolguy sgtcoolguy merged commit 5978197 into tidev:8_1_X Aug 20, 2019
rlustemberg added a commit to inzdr/titanium_mobile that referenced this pull request Aug 21, 2019
* 8_1_X: (46 commits)
  fix(ios): exclude all frameworks from optimizing files step (8_1_X) (tidev#10996)
  fix(android): fix asset encryption on windows 32bit java (tidev#11155)
  fix(ios): add script message handler for local files only (tidev#11086)
  fix(android): improve merge of <uses-feature/> elements (tidev#11111)
  fix(android): splash open animation sometimes stutters on cold start (tidev#11140)
  fix(android): fix dialog without selectedIndex reusage
  fix(android): resuming with intent "FLAG_ACTIVITY_MULTIPLE_TASK" can hang the app (tidev#11081)
  fix(android): regression where closing root window from child window causes app exit issues as of 8.0.1 (tidev#11093)
  fix(android): fix reusing a dialog with a new "parent" window (tidev#11096)
  chore(release): bump version
  fix(ios): console.log does not log properly if it has multiple arguments (tidev#11125)
  fix(android): update titanium_prep windows binaries
  chore(android)(8_1_X): update titanium_prep binaries (tidev#11100)
  fix(android)(8_1_X): ListView's SearchBar/SearchView wrongly overlaps rows as of 8.0.1 (tidev#11105)
  chore(android): update aps-analytics (tidev#11101)
  fix(ios): fix crashes in calendar upon giving permission (tidev#11078)
  fix(ios,android)(8_1_X): implement exception signal handler (tidev#11077)
  fix(cli): add deprecation notice for node < 10.13 (tidev#11063)
  test(db): bump up timeout
  test(db): drop long-running query count to 5000 rows
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants