fix(ios): console.log does not log properly if it has multiple arguments #11125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests:
|
sgtcoolguy
reviewed
Aug 12, 2019
| @@ -14,6 +14,9 @@ JSExportAs(timeLog, | |||
| -(void)timeLog | |||
| : (id)args withData | |||
| : (NSArray *)logData); | |||
| JSExportAs(log, | |||
There was a problem hiding this comment.
I'm not sure this is actually required as the log method is exported by the APIModule parent class...
ssjsamir
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
FR Passed: console.log now logs properly if it has multiple arguments.
Tested with the following test case:
const win = Ti.UI.createWindow({
backgroundColor: '#fff'
});
const button = Ti.UI.createButton({
title: 'Log'
});
button.addEventListener('click', function(e){
console.log(1, ' test', true);
});
win.add(button);
win.open();
Test Environment
MacOS Mojave version 10.14.4
Xcode 10.3
Node.js ^8.12.0
iPhone 8 (13).
"NPM":"4.2.13","CLI":"7.0.11
rlustemberg
added a commit
to inzdr/titanium_mobile
that referenced
this pull request
Aug 21, 2019
* 8_1_X: (46 commits) fix(ios): exclude all frameworks from optimizing files step (8_1_X) (tidev#10996) fix(android): fix asset encryption on windows 32bit java (tidev#11155) fix(ios): add script message handler for local files only (tidev#11086) fix(android): improve merge of <uses-feature/> elements (tidev#11111) fix(android): splash open animation sometimes stutters on cold start (tidev#11140) fix(android): fix dialog without selectedIndex reusage fix(android): resuming with intent "FLAG_ACTIVITY_MULTIPLE_TASK" can hang the app (tidev#11081) fix(android): regression where closing root window from child window causes app exit issues as of 8.0.1 (tidev#11093) fix(android): fix reusing a dialog with a new "parent" window (tidev#11096) chore(release): bump version fix(ios): console.log does not log properly if it has multiple arguments (tidev#11125) fix(android): update titanium_prep windows binaries chore(android)(8_1_X): update titanium_prep binaries (tidev#11100) fix(android)(8_1_X): ListView's SearchBar/SearchView wrongly overlaps rows as of 8.0.1 (tidev#11105) chore(android): update aps-analytics (tidev#11101) fix(ios): fix crashes in calendar upon giving permission (tidev#11078) fix(ios,android)(8_1_X): implement exception signal handler (tidev#11077) fix(cli): add deprecation notice for node < 10.13 (tidev#11063) test(db): bump up timeout test(db): drop long-running query count to 5000 rows ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-27313
console.log has different behavior from Titanium.API.log