Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(8_1_X): Closing root window from child window causes app exit issues as of 8.0.1 #11093

Merged
merged 3 commits into from Aug 20, 2019

Conversation

jquick-axway
Copy link
Contributor

…m child window causes app exit issues as of 8.0.1

- Caused immediate child window to home-out instead of exiting app when closed.
- Caused child window's child to wrongly exit app when closed.
@build
Copy link
Contributor

build commented Jul 30, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3728 tests are passing.
(There are 470 tests skipped)

Generated by 🚫 dangerJS against f2b7ec4

@keerthi1032
Copy link
Contributor

FR passed. app works as expected with Close Root Window Test and exitOnClose Test. Waiting for 8.1.0.GA release to merge PR

Test Environment:
Operating System
Name = Mac OS X
Version = 10.14.5
Architecture = 64bit
Node.js
Node.js Version = 10.16.0
npm Version = 6.9.0
Titanium CLI
CLI Version = 5.2.1
Titanium SDK
SDK Version = local sdk 8.2.0.v20190621202814 and 8.1.0.v20190725194646.
Device = Oneplus 5T android 9,
EMulator = nexus 6p android 8,pixel android 9

@sgtcoolguy sgtcoolguy merged commit 57dfc5d into tidev:8_1_X Aug 20, 2019
rlustemberg added a commit to inzdr/titanium_mobile that referenced this pull request Aug 21, 2019
* 8_1_X: (46 commits)
  fix(ios): exclude all frameworks from optimizing files step (8_1_X) (tidev#10996)
  fix(android): fix asset encryption on windows 32bit java (tidev#11155)
  fix(ios): add script message handler for local files only (tidev#11086)
  fix(android): improve merge of <uses-feature/> elements (tidev#11111)
  fix(android): splash open animation sometimes stutters on cold start (tidev#11140)
  fix(android): fix dialog without selectedIndex reusage
  fix(android): resuming with intent "FLAG_ACTIVITY_MULTIPLE_TASK" can hang the app (tidev#11081)
  fix(android): regression where closing root window from child window causes app exit issues as of 8.0.1 (tidev#11093)
  fix(android): fix reusing a dialog with a new "parent" window (tidev#11096)
  chore(release): bump version
  fix(ios): console.log does not log properly if it has multiple arguments (tidev#11125)
  fix(android): update titanium_prep windows binaries
  chore(android)(8_1_X): update titanium_prep binaries (tidev#11100)
  fix(android)(8_1_X): ListView's SearchBar/SearchView wrongly overlaps rows as of 8.0.1 (tidev#11105)
  chore(android): update aps-analytics (tidev#11101)
  fix(ios): fix crashes in calendar upon giving permission (tidev#11078)
  fix(ios,android)(8_1_X): implement exception signal handler (tidev#11077)
  fix(cli): add deprecation notice for node < 10.13 (tidev#11063)
  test(db): bump up timeout
  test(db): drop long-running query count to 5000 rows
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants