Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): fix reusing a dialog with a new "parent" window (8_1_X) #11096

Merged
merged 2 commits into from Aug 19, 2019

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Jul 31, 2019

(cherry picked from commit 62a46fb)

JIRA: https://jira.appcelerator.org/browse/TIMOB-27256

Description:
Backport of: #11073

@ypbnv ypbnv added this to the 8.1.0 milestone Jul 31, 2019
@ypbnv ypbnv requested a review from jquick-axway July 31, 2019 14:36
@ypbnv ypbnv changed the title fix(android): fix reusing a dialog with a new "parent" window fix(android): fix reusing a dialog with a new "parent" window (8_1_X) Jul 31, 2019
@build build requested a review from a team July 31, 2019 15:08
@build
Copy link
Contributor

build commented Jul 31, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3728 tests are passing.
(There are 470 tests skipped)

Generated by 🚫 dangerJS against b2833ee

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssekhri
Copy link

ssekhri commented Aug 19, 2019

FR Passed. Dialog re-use works successfully.
Verified on:
Mac OS 10.14.6
Ti SDK: 8.1.0.v20190731073941
Appc CLI: 7.1.1-master.2
Node: 8.16.0
JDK: 10.0.2
Xcode: 10.3
Studio: 5.1.3.201907112159

@ssekhri ssekhri merged commit 7abdbcd into tidev:8_1_X Aug 19, 2019
rlustemberg added a commit to inzdr/titanium_mobile that referenced this pull request Aug 21, 2019
* 8_1_X: (46 commits)
  fix(ios): exclude all frameworks from optimizing files step (8_1_X) (tidev#10996)
  fix(android): fix asset encryption on windows 32bit java (tidev#11155)
  fix(ios): add script message handler for local files only (tidev#11086)
  fix(android): improve merge of <uses-feature/> elements (tidev#11111)
  fix(android): splash open animation sometimes stutters on cold start (tidev#11140)
  fix(android): fix dialog without selectedIndex reusage
  fix(android): resuming with intent "FLAG_ACTIVITY_MULTIPLE_TASK" can hang the app (tidev#11081)
  fix(android): regression where closing root window from child window causes app exit issues as of 8.0.1 (tidev#11093)
  fix(android): fix reusing a dialog with a new "parent" window (tidev#11096)
  chore(release): bump version
  fix(ios): console.log does not log properly if it has multiple arguments (tidev#11125)
  fix(android): update titanium_prep windows binaries
  chore(android)(8_1_X): update titanium_prep binaries (tidev#11100)
  fix(android)(8_1_X): ListView's SearchBar/SearchView wrongly overlaps rows as of 8.0.1 (tidev#11105)
  chore(android): update aps-analytics (tidev#11101)
  fix(ios): fix crashes in calendar upon giving permission (tidev#11078)
  fix(ios,android)(8_1_X): implement exception signal handler (tidev#11077)
  fix(cli): add deprecation notice for node < 10.13 (tidev#11063)
  test(db): bump up timeout
  test(db): drop long-running query count to 5000 rows
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants