Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): call WebView.stopLoading() from main thread #11169

Closed
wants to merge 2 commits into from

Conversation

garymathews
Copy link
Contributor

  • Allow Titanium.UI.WebView.stopLoading() to function when called from events
TEST CASE
const win = Ti.UI.createWindow();
const webView = Ti.UI.createWebView({ url: 'https://google.com/' });

webView.addEventListener('beforeload', e => {
    webView.stopLoading();
});

win.add(webView);
win.open();

JIRA Ticket

@build
Copy link
Contributor

build commented Aug 22, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4372 tests are passing.
(There are 472 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against ce27c24

Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I did not see the discussion in the 8_1_X backport. Sorry!

@ypbnv ypbnv self-requested a review August 29, 2019 15:02
@garymathews
Copy link
Contributor Author

Closing, marked for 8_3_X

@garymathews garymathews closed this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants