Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): call WebView.stopLoading() from main thread #11170

Merged
merged 4 commits into from
Sep 13, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Aug 22, 2019

  • Allow Titanium.UI.WebView.stopLoading() to function when called from events
TEST CASE
const win = Ti.UI.createWindow();
const webView = Ti.UI.createWebView({ url: 'https://google.com/' });

webView.addEventListener('beforeload', e => {
    webView.stopLoading();
});

win.add(webView);
win.open();

JIRA Ticket

@garymathews garymathews added this to the 8.3.0 milestone Aug 22, 2019
@garymathews garymathews requested a review from ypbnv August 22, 2019 18:15
@build build requested a review from a team August 22, 2019 18:55
@build
Copy link
Contributor

build commented Aug 22, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4336 tests are passing.
(There are 471 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against b268be7

@sgtcoolguy sgtcoolguy changed the base branch from 8_3_X to master September 9, 2019 18:03
@sgtcoolguy sgtcoolguy changed the title fix(android)(8_3_X): call WebView.stopLoading() from main thread fix(android): call WebView.stopLoading() from main thread Sep 9, 2019
@sgtcoolguy sgtcoolguy requested review from jquick-axway and removed request for ypbnv September 10, 2019 13:50
@sgtcoolguy
Copy link
Contributor

Pinging @jquick-axway for CR since he had already had some feedback/discussion on the closed 8_1_X backport at #11171

@ssekhri
Copy link

ssekhri commented Sep 12, 2019

FR passed.
Verified on:
Mac OS 10.14.6
Ti SDK: 8.3.0.v20190910145509
Appc CLI: 7.1.1
Node: 10.5.0
JDK: 10.0.2
Studio: 5.1.4.201909061933
Device: Nexus 4(5.1.1), Android emulator (v8.0)

@ssekhri
Copy link

ssekhri commented Sep 12, 2019

Waiting for CR @jquick-axway

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssekhri ssekhri merged commit 438a43a into tidev:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants