Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): app crashes when error happens in fetching location #11273

Merged
merged 2 commits into from Oct 14, 2019
Merged

fix(ios): app crashes when error happens in fetching location #11273

merged 2 commits into from Oct 14, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.3.0 milestone Oct 9, 2019
@build build requested a review from a team October 9, 2019 20:28
@build
Copy link
Contributor

build commented Oct 9, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 4122 tests are passing.
(There are 469 skipped tests not included in that total)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 320b5b8

sgtcoolguy
sgtcoolguy approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes LGTM

@ssaddique ssaddique modified the milestones: 8.3.0, 8.2.1 Oct 14, 2019
@ssaddique ssaddique merged commit 6100379 into tidev:master Oct 14, 2019
@ssaddique
Copy link
Contributor

FR: Passed. I have confirmed that this issue affects > iOS 12. This does not affect < iOS 12. PR Merged.

Test Environment
Studio Ver: 5.1.4.201909061933
SDK Ver: 8.3.0 (PR-11273)
OS Ver: 10.14.6
Xcode Ver: Xcode 11.1
Appc NPM: 4.2.15
Appc CLI: 7.1.1
Alloy Ver: 1.14.1
Node Ver: 10.16.3
NPM Ver: 6.11.3
Devices: iPhone 7 (iOS 13), iPhone 6 (iOS 12), iPhone 6 (iOS 11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vijaysingh-axway @build @ssaddique @sgtcoolguy