Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): app crashes when error happens in fetching location #11273

Merged
merged 2 commits into from
Oct 14, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions iphone/Classes/GeolocationModule.m
Original file line number Diff line number Diff line change
Expand Up @@ -1086,11 +1086,12 @@ - (void)locationManager:(CLLocationManager *)manager didUpdateToLocation:(CLLoca

- (void)locationManager:(CLLocationManager *)manager didFailWithError:(NSError *)error
{
NSMutableDictionary *event = [TiUtils dictionaryWithCode:[error code] message:[TiUtils messageFromError:error]];

if ([self _hasListeners:@"location"]) {
[self fireEvent:@"location" withObject:nil errorCode:[error code] message:[TiUtils messageFromError:error]];
[self fireEvent:@"location" withDict:event];
}

NSMutableDictionary *event = [TiUtils dictionaryWithCode:[error code] message:[TiUtils messageFromError:error]];
BOOL recheck = [self fireSingleShotLocationIfNeeded:event stopIfNeeded:NO];
recheck = recheck || [self fireSingleShotHeadingIfNeeded:event stopIfNeeded:NO];

Expand Down