New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): support Geolocation altitudeAccuracy #11275
Conversation
|
private KrollDict buildLocationEvent(Location location, LocationProvider locationProvider) | ||
{ | ||
KrollDict coordinates = new KrollDict(); | ||
coordinates.put(TiC.PROPERTY_LATITUDE, location.getLatitude()); | ||
coordinates.put(TiC.PROPERTY_LONGITUDE, location.getLongitude()); | ||
coordinates.put(TiC.PROPERTY_ALTITUDE, location.getAltitude()); | ||
coordinates.put(TiC.PROPERTY_ACCURACY, location.getAccuracy()); | ||
coordinates.put(TiC.PROPERTY_ALTITUDE_ACCURACY, null); // Not provided | ||
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I'd prefer to see the actual api version it is supported from. I'm not sure too many people are familiar with the "brand name" to api level mappings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the API version is less important here, it's nice to see what Android version supports altitude accuracy (i.e most people know Android Oreo is 8.0, where 26
would be less obvious).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add to apidocs
FR: Passed. Test Environment
|
altitudeAccuracy
on Android API 26+TEST CASE
null
asaltitudeAccuracy
on Android 26+JIRA Ticket