Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): support Geolocation altitudeAccuracy #11275

Merged
merged 5 commits into from
Oct 16, 2019
Merged

fix(android): support Geolocation altitudeAccuracy #11275

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c95f35
fix(android): support altitude_accuracy on android 26+
Oct 10, 2019
d928282
docs(android): specify min supported android version
Oct 10, 2019
c566eac
Merge branch 'master' into TIMOB-20362
garymathews Oct 10, 2019
52df5cd
Merge branch 'master' into TIMOB-20362
garymathews Oct 14, 2019
e1b0ae9
Merge branch 'master' into TIMOB-20362
ssaddique Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion android/modules/geolocation/src/java/ti/modules/titanium/geolocation/GeolocationModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,14 +786,19 @@ private boolean shouldUseUpdate(Location newLocation)
* @return map of property names and values that contain information
* pulled from the specified location
*/
@SuppressWarnings("NewApi")
private KrollDict buildLocationEvent(Location location, LocationProvider locationProvider)
{
KrollDict coordinates = new KrollDict();
coordinates.put(TiC.PROPERTY_LATITUDE, location.getLatitude());
coordinates.put(TiC.PROPERTY_LONGITUDE, location.getLongitude());
coordinates.put(TiC.PROPERTY_ALTITUDE, location.getAltitude());
coordinates.put(TiC.PROPERTY_ACCURACY, location.getAccuracy());
coordinates.put(TiC.PROPERTY_ALTITUDE_ACCURACY, null); // Not provided
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'd prefer to see the actual api version it is supported from. I'm not sure too many people are familiar with the "brand name" to api level mappings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the API version is less important here, it's nice to see what Android version supports altitude accuracy (i.e most people know Android Oreo is 8.0, where 26 would be less obvious).

coordinates.put(TiC.PROPERTY_ALTITUDE_ACCURACY, location.getVerticalAccuracyMeters());
} else {
coordinates.put(TiC.PROPERTY_ALTITUDE_ACCURACY, null);
}
coordinates.put(TiC.PROPERTY_HEADING, location.getBearing());
coordinates.put(TiC.PROPERTY_SPEED, location.getSpeed());
coordinates.put(TiC.PROPERTY_TIMESTAMP, location.getTime());
Expand Down
1 change: 1 addition & 0 deletions apidoc/Titanium/Geolocation/Geolocation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,6 +869,7 @@ properties:
- name: altitudeAccuracy
summary: Vertical accuracy of the location update, in meters.
type: Number
osver: { android: { min: "8.0.0" } }

- name: heading
summary: |
Expand Down