Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xcodebuild dest, bump min iOS target to 9, disable ONLY_ACTIVE_ARCH for 32-bit sims #11282

Merged
merged 6 commits into from Oct 21, 2019
Merged

Fix xcodebuild dest, bump min iOS target to 9, disable ONLY_ACTIVE_ARCH for 32-bit sims #11282

merged 6 commits into from Oct 21, 2019

Conversation

cb1kenobi
Copy link
Contributor

@cb1kenobi cb1kenobi commented Oct 15, 2019 •
edited

@build build added this to the 8.2.1 milestone Oct 15, 2019
@build
Copy link
Contributor

build commented Oct 15, 2019 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ❌ 9 tests have failed There are 9 tests failing and 471 skipped out of 4336 total tests.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

ClassnameNameTimeError
ios.Titanium.UI.LayoutTIMOB-23372 #100.001
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/ti.ui.layout.test.js:1792:33
ios.Titanium.UI.LayoutTIMOB-23372 #90.002
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/ti.ui.layout.test.js:1762:33
ios.Titanium.UI.LayoutTIMOB-23372 #80.002
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/ti.ui.layout.test.js:1732:33
ios.Titanium.UI.LayoutTIMOB-23372 #70.002
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/ti.ui.layout.test.js:1699:33
ios.Titanium.UI.LayoutTIMOB-23372 #60.002
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/ti.ui.layout.test.js:1654:33
ios.Titanium.UI.LayoutTIMOB-23372 #50.003
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/ti.ui.layout.test.js:1609:33
ios.Titanium.UI.LayoutTIMOB-23372 #40.002
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/ti.ui.layout.test.js:1566:33
ios.Titanium.UI.LayoutTIMOB-23372 #30.003
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/ti.ui.layout.test.js:1522:33
ios.Titanium.UI.LayoutTIMOB-23372 #20.003
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/9ADB430A-7EEE-44C0-813F-C382D30D2AD6/mocha.app/ti.ui.layout.test.js:1477:33

Dependencies with modified semantic versioning:

  • ioslib - from ^1.7.14 to ^1.7.15

Generated by 🚫 dangerJS against 4e03626

@ssekhri
Copy link

ssekhri commented Oct 15, 2019

FR Passed.
Verified On:
Mac OS: 10.14.5
SDK: 8.2.1.v20191015074712
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.0, 10.3
iOS simulator v13.0, 12.4, 12.2

ewanharris
ewanharris approved these changes Oct 16, 2019
View reviewed changes
Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cb1kenobi cb1kenobi changed the title fix(ios): break outer dest loop if dest found Fix xcodebuild dest, bump min iOS target to 9, disable ONLY_ACTIVE_ARCH for 32-bit sims Oct 17, 2019
cb1kenobi and others added 5 commits October 18, 2019 13:32
@cb1kenobi @ewanharris
fix(ios): break outer dest loop if dest found
0874395
@cb1kenobi @ewanharris
fix(ios): xcode 11 fixes
65cceae 
* Bumped min iOS target from 8 to 9.
* For sim builds, only build active arch for 64-bit sim devices.
* Only create legacy launch image asset catalog when using Xcode 10 and older.
@cb1kenobi @ewanharris
fix(ios): reenabled launch images
1cac787
@cb1kenobi @ewanharris
chore(ios): improved comment
eed00f8
@ewanharris
chore(deps): update to ioslib v.1.7.15
18f53bd
@ewanharris ewanharris mentioned this pull request Oct 18, 2019
Merged
@lokeshchdhry
Copy link
Contributor

FR Passed.

Followed tests here tidev/ioslib#102 (comment)

SDK: 8.2.1 local build

@sgtcoolguy sgtcoolguy merged commit b025431 into tidev:8_2_X Oct 21, 2019
@cb1kenobi cb1kenobi deleted the TIMOB-27338_8_2_X branch October 21, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
in-qe-testing 🕵
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cb1kenobi @build @ssekhri @lokeshchdhry @ewanharris @sgtcoolguy