Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(8_3_X): do not modify original ListView proxy #11323

Merged
merged 2 commits into from Nov 11, 2019
Merged

fix(android)(8_3_X): do not modify original ListView proxy #11323

merged 2 commits into from Nov 11, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 8.3.0 milestone Nov 11, 2019
@build build requested a review from a team November 11, 2019 19:59
@build
Copy link
Contributor

build commented Nov 11, 2019 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ❌ 24 tests have failed There are 24 tests failing and 711 skipped out of 7334 total tests.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.TabGroup#setActiveTab()9.304
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
ios.ipad.Titanium.UI.ListViewdeleteSectionAt60
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.ListViewreplaceSectionAt60
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.ListViewinsertSectionAt60.001
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.ListViewappendSection59.999
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.ListViewCustom template60.001
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.ListViewheaderView60
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.ListViewsection header & footer60.001
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.Windowwindow_navigation2.518
Error: expected 0 to equal 2
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti.ui.window.test.js:732:8037
ios.ipad.Titanium.UI.WindowTIMOB-2060030.001
Error: timeout of 30000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53348
ios.ipad.Titanium.UI.Windowwindow_close_order_220.001
Error: timeout of 20000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53348
ios.ipad.Titanium.UI.Windowwindow_close_order_130.002
Error: timeout of 30000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53348
ios.ipad.Titanium.UI.Window#remove(View)20.003
Error: timeout of 20000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53348
ios.ipad.Titanium.UI.TableViewTIMOB-26164 : updateRow + insertRowAfter causing crash on main thread5.002
Error: timeout of 5000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.TableViewDelete row (Search Active)5.003
Error: timeout of 5000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.TextFieldheight5.002
Error: timeout of 5000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53348
ios.ipad.Titanium.UI.View.accessibility* Properties10.001
Error: timeout of 10000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.Viewevent source and bubbles property10.003
Error: timeout of 10000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.WebViewurl(local)30.001
Error: timeout of 30000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.WebViewkeyboardDisplayRequiresUserAction30
Error: timeout of 30000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.WebViewurl30.002
Error: timeout of 30000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.Window.eventsfocus event is fired when opened20.002
Error: timeout of 20000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.UI.Window.eventsblur event is fired when closed20.001
Error: timeout of 20000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53951
ios.ipad.Titanium.Utils#base64encode(Ti.Blob#TYPE_DATA from Ti.UI.View.toImage() async)5.001
Error: timeout of 5000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/1ABD275D-943B-4670-BCE9-89440C554A15/data/Containers/Bundle/Application/3F536036-EBCC-434B-8A16-ABF71D7CF8C4/mocha.app/ti-mocha.js:6535:53348

Generated by 🚫 dangerJS against 548bf13

@lokeshchdhry
Copy link
Contributor

FR Passed.

Studio Ver: 5.1.4.201909061933
SDK Ver: 8.3.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 11.1
Appc NPM: 4.2.15
Appc CLI: 7.1.2-master.5
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.2
Alloy Ver: 1.14.2
Node Ver: 12.13.0
NPM Ver: 6.12.0
Java Ver: 10.0.2
Android Devices: ⇨ google Pixel (Android 9)
Android Emulator: ⇨ Android 4.4.2

@sgtcoolguy sgtcoolguy merged commit b3a0306 into tidev:8_3_X Nov 11, 2019
@build build mentioned this pull request Nov 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug no tests
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @lokeshchdhry @sgtcoolguy