fix(android): move for validation

tidev · Nov 11, 2019 · 548bf13 · 548bf13
1 parent 7e29095
commit 548bf13
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/ListItemProxy.java b/android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/ListItemProxy.java
@@ -54,13 +54,13 @@ private void fireItemClick(String event, Object data)
 		if (event.equals(TiC.EVENT_CLICK) && data instanceof HashMap) {
 			KrollDict eventData = new KrollDict((HashMap) data);
 			TiViewProxy source = (TiViewProxy) eventData.get(TiC.EVENT_PROPERTY_SOURCE);
-
-			// FIXME: We should not need to create a placeholder proxy for each item. ListView needs refactoring to remedy this.
-			source = (TiViewProxy) KrollProxy.createProxy(source.getClass(), source.getKrollObject(), new Object[0],
-														  source.getCreationUrl().url);
-			eventData.put(TiC.EVENT_PROPERTY_SOURCE, source);
 			if (source != null && !source.equals(this) && listProxy != null) {
 
+				// FIXME: We should not need to create a placeholder proxy for each item. ListView needs refactoring to remedy this.
+				source = (TiViewProxy) KrollProxy.createProxy(source.getClass(), source.getKrollObject(), new Object[0],
+															  source.getCreationUrl().url);
+				eventData.put(TiC.EVENT_PROPERTY_SOURCE, source);
+
 				// append bind properties
 				if (eventData.containsKey(TiC.PROPERTY_BIND_ID) && eventData.containsKey(TiC.PROPERTY_ITEM_INDEX)
 					&& eventData.containsKey(TiC.PROPERTY_SECTION)) {