Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ios, android): remove deprecated APIs #11386

Merged
merged 26 commits into from Dec 16, 2019

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented Dec 10, 2019

JIRA: https://jira.appcelerator.org/browse/TIMOB-27617

Description:
Follow-on to #11368

This is an attempt to include more removals, updated docs for long-deprecated APIs

  • Ti.Android.Activity events create, destroy, restart, resume, start and stop are removed here for 9.0.0 (we have properties to register callback function for these lifecycle hooks)
  • Ti.UI.TabGroup selected/unselected events are removed here in 9.0.0 (use blur/focus)
  • Ti.UI.Tab blur/focus events are removed here for 9.0.0 (use selected/unselected)
  • Ti.Contacts #getGroupByID(), #getPersonByID(), #requestAuthorization() methods removed here for 9.0.0
  • Ti.Calendar #requestEventsAuthorization() and #requestAuthorization() methods were removed in 8.1.0
  • Ti.Media #requestAudioPermissions(), #requestCameraAccess(), #requestAuthorization() methods removed here for 9.0.0
  • Ti.UI.Android.CardView card* properties were removed in 6.0.0
  • Ti.UI.TextField and Ti.UI.TextArea appearance property removed here for 9.0.0 (use keyboardAppearance)
  • Ti.Ui.TextField paddingRight and paddingLeft properties removed here for 9.0.0 (use padding.right and padding.left)
  • Ti.Gesture #isPortrait() and #isLandscape() were removed in 7.0.0 on Android, 8.1.0 on iOS

BREAKING CHANGE: Removes the create, destroy, pause, restart, resume, start, and stop events on Ti.Android.Activity (use callback properties)
BREAKING CHANGES: removes Ti.UI.TabGroup selected/unselected events in favor of focus/blur
BREAKING CHANGES: removes Ti.UI.Tab blur/focus events in favor of selected/unselected
BREAKING CHANGES: removes Ti.Contacts getGroupByID and getPersonByID methods (in favor of getGroupByIdentifier and getPersonByIdentifier)
BREAKING CHANGES: removes Ti.Contacts getPersonByID method (in favor of getPersonByIdentifier)
BREAKING CHANGES: removes Ti.Contacts requestAuthorization method (in favor of requestContactsPermissions)
BREAKING CHANGES: removes Ti.Contacts requestAuthorization method (in favor of requestContactsPermissions)
BREAKING CHANGES: removes Ti.Media requestAuthorization and requestCameraAccess methods (in favor of requestAudioRecorderPermissions and requestCameraPermissions)
BREAKING CHANGES: removes Ti.Media requestAudioPermissions method (in favor of requestAudioRecorderPermissions)
BREAKING CHANGES: removes Ti.UI.TextArea, Ti.UI.TextField appearance property (in favor of keyboardAppearance)
BREAKING CHANGES: removes Ti.UI.TextField paddingLeft and paddingRight properties (in favor of padding.left and padding.right)
@build build added this to the 9.0.0 milestone Dec 10, 2019
@build build requested review from a team December 10, 2019 16:19
@build
Copy link
Contributor

build commented Dec 10, 2019

Warnings
⚠️

android/cli/commands/_build.js#L3288 - android/cli/commands/_build.js line 3288 – 'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead. (node/no-deprecated-api)

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6661 tests are passing.
(There are 700 skipped tests not included in that total)

Generated by 🚫 dangerJS against b681b34

@sgtcoolguy sgtcoolguy marked this pull request as ready for review December 10, 2019 19:16
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android part looks good.

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS changes looks good

@sgtcoolguy sgtcoolguy merged commit e562969 into tidev:master Dec 16, 2019
@sgtcoolguy sgtcoolguy deleted the more-removals branch December 16, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants