refactor(ios, android): remove deprecated APIs

android/cli/commands/_build.js

@@ -3639,11 +3639,9 @@ AndroidBuilder.prototype.generateAndroidManifest = function generateAndroidManif
 			'Contacts.getAllContacts': contactsReadPermissions,
 			'Contacts.showContactPicker': contactsReadPermissions,
 			'Contacts.showContacts': contactsReadPermissions,
-			'Contacts.getPersonByID': contactsReadPermissions,
 			'Contacts.getPeopleWithName': contactsReadPermissions,
 			'Contacts.getAllPeople': contactsReadPermissions,
 			'Contacts.getAllGroups': contactsReadPermissions,
-			'Contacts.getGroupByID': contactsReadPermissions,
 
 			'Media.Android.setSystemWallpaper': wallpaperPermissions,
 			'Media.showCamera': cameraPermissions,

android/modules/contacts/src/java/ti/modules/titanium/contacts/ContactsModule.java

@@ -134,16 +134,6 @@ public void save(Object people)
 		contactsApi.save(people);
 	}
 
-	@Kroll.method
-	public PersonProxy getPersonByID(long id)
-	{
-		Log.w(
-			TAG,
-			"Ti.Contacts.getPersonByID() has been deprecated in favor of Ti.Contacts.getPersonByIdentifier() for cross-platform parity",
-			Log.DEBUG_MODE);
-		return contactsApi.getPersonById(id);
-	}
-
 	@Kroll.method
 	public PersonProxy getPersonByIdentifier(long id)
 	{
@@ -156,14 +146,6 @@ public void removePerson(PersonProxy person)
 		contactsApi.removePerson(person);
 	}
 
-	@Kroll.method
-	public void requestAuthorization(KrollFunction function)
-	{
-		KrollDict dict = new KrollDict();
-		dict.putCodeAndMessage(TiC.ERROR_CODE_NO_ERROR, null);
-		function.callAsync(getKrollObject(), dict);
-	}
-
 	@Kroll.method
 	public void showContacts(@Kroll.argument(optional = true) KrollDict d)
 	{

android/titanium/src/java/org/appcelerator/titanium/TiBaseActivity.java

@@ -753,7 +753,6 @@ public void onChanged(TiActivitySafeAreaMonitor monitor)
 		}
 		if (activityProxy != null) {
 			dispatchCallback(TiC.PROPERTY_ON_CREATE, null);
-			activityProxy.fireEvent(TiC.EVENT_CREATE, null);
 		}
 		synchronized (lifecycleListeners.synchronizedList())
 		{
@@ -1303,10 +1302,6 @@ protected void onPause()
 			releaseDialogs(false);
 		}
 
-		if (activityProxy != null) {
-			activityProxy.fireEvent(TiC.EVENT_PAUSE, null);
-		}
-
 		synchronized (lifecycleListeners.synchronizedList())
 		{
 			for (OnLifecycleEvent listener : lifecycleListeners.nonNull()) {
@@ -1344,10 +1339,6 @@ protected void onResume()
 		tiApp.setCurrentActivity(this, this);
 		TiApplication.updateActivityTransitionState(false);
 
-		if (activityProxy != null) {
-			activityProxy.fireEvent(TiC.EVENT_RESUME, null);
-		}
-
 		synchronized (lifecycleListeners.synchronizedList())
 		{
 			for (OnLifecycleEvent listener : lifecycleListeners.nonNull()) {
@@ -1386,20 +1377,6 @@ protected void onStart()
 
 		updateTitle();
 
-		if (activityProxy != null) {
-			// we only want to set the current activity for good in the resume state but we need it right now.
-			// save off the existing current activity, set ourselves to be the new current activity temporarily
-			// so we don't run into problems when we give the proxy the event
-			TiApplication tiApp = getTiApp();
-			Activity tempCurrentActivity = tiApp.getCurrentActivity();
-			tiApp.setCurrentActivity(this, this);
-
-			activityProxy.fireEvent(TiC.EVENT_START, null);
-
-			// set the current activity back to what it was originally
-			tiApp.setCurrentActivity(this, tempCurrentActivity);
-		}
-
 		synchronized (lifecycleListeners.synchronizedList())
 		{
 			for (OnLifecycleEvent listener : lifecycleListeners.nonNull()) {
@@ -1426,10 +1403,6 @@ protected void onStop()
 
 		Log.d(TAG, "Activity " + this + " onStop", Log.DEBUG_MODE);
 
-		if (activityProxy != null) {
-			activityProxy.fireEvent(TiC.EVENT_STOP, null);
-		}
-
 		synchronized (lifecycleListeners.synchronizedList())
 		{
 			for (OnLifecycleEvent listener : lifecycleListeners.nonNull()) {
@@ -1455,20 +1428,6 @@ protected void onRestart()
 		super.onRestart();
 
 		Log.d(TAG, "Activity " + this + " onRestart", Log.DEBUG_MODE);
-
-		if (activityProxy != null) {
-			// we only want to set the current activity for good in the resume state but we need it right now.
-			// save off the existing current activity, set ourselves to be the new current activity temporarily
-			// so we don't run into problems when we give the proxy the event
-			TiApplication tiApp = getTiApp();
-			Activity tempCurrentActivity = tiApp.getCurrentActivity();
-			tiApp.setCurrentActivity(this, this);
-
-			activityProxy.fireEvent(TiC.EVENT_RESTART, null);
-
-			// set the current activity back to what it was originally
-			tiApp.setCurrentActivity(this, tempCurrentActivity);
-		}
 	}
 
 	@Override
@@ -1644,9 +1603,6 @@ protected void onRestoreInstanceState(Bundle savedInstanceState)
 	protected void fireOnDestroy()
 	{
 		if (!onDestroyFired) {
-			if (activityProxy != null) {
-				activityProxy.fireEvent(TiC.EVENT_DESTROY, null);
-			}
 			onDestroyFired = true;
 		}
 	}

android/titanium/src/java/org/appcelerator/titanium/TiC.java

@@ -125,11 +125,6 @@ public class TiC
 	 */
 	public static final String EVENT_COMPLETE = "complete";
 
-	/**
-	 * @module.api
-	 */
-	public static final String EVENT_CREATE = "create";
-
 	/**
 	 * @module.api
 	 */
@@ -544,11 +539,6 @@ public class TiC
 	 */
 	public static final String EVENT_REGION_CHANGED = "regionchanged";
 
-	/**
-	 * @module.api
-	 */
-	public static final String EVENT_RESTART = "restart";
-
 	/**
 	 * @module.api
 	 */

apidoc/Titanium/Android/Activity.yml

@@ -243,6 +243,7 @@ events:
     summary: Fired from the activity's `onCreate` method.
     deprecated:
         since: "3.4.0"
+        removed: "9.0.0"
         notes: Use [Titanium.Android.Activity.onCreate](Titanium.Android.Activity.onCreate) instead.
     description: |
         See also:
@@ -253,6 +254,7 @@ events:
     summary: Fired from the activity's `onDestroy` method.
     deprecated:
         since: "3.4.0"
+        removed: "9.0.0"
         notes: Use [Titanium.Android.Activity.onDestroy](Titanium.Android.Activity.onDestroy) instead.
     description: |
         See also: [onDestroy](https://developer.android.com/reference/android/app/Activity.html#onDestroy())
@@ -287,16 +289,28 @@ events:
     summary: Fired when the activity is paused.
     deprecated:
         since: "3.4.0"
+        removed: "9.0.0"
         notes: Use [Titanium.Android.Activity.onPause](Titanium.Android.Activity.onPause) instead.
     description: |
         See also:
         [onPause](https://developer.android.com/reference/android/app/Activity.html#onPause())
         in the Android Developer Reference.
 
+  - name: restart
+    summary: Fired when the activity is restarted.
+    deprecated:
+        since: "3.4.0"
+        removed: "9.0.0"
+        notes: Use [Titanium.Android.Activity.onRestart](Titanium.Android.Activity.onRestart) instead.
+    description: |
+        See also: [onRestart](https://developer.android.com/reference/android/app/Activity.html#onRestart())
+        in the Android Developer Reference.
+
   - name: resume
     summary: Fired when the activity is resumed.
     deprecated:
         since: "3.4.0"
+        removed: "9.0.0"
         notes: Use [Titanium.Android.Activity.onResume](Titanium.Android.Activity.onResume) instead.
     description: |
         See also: [onResume](https://developer.android.com/reference/android/app/Activity.html#onResume())
@@ -306,6 +320,7 @@ events:
     summary: Fired when the activity is started.
     deprecated:
         since: "3.4.0"
+        removed: "9.0.0"
         notes: Use [Titanium.Android.Activity.onStart](Titanium.Android.Activity.onStart) instead.
     description: |
         See also: [onStart](https://developer.android.com/reference/android/app/Activity.html#onStart())
@@ -315,6 +330,7 @@ events:
     summary: Fired when the activity is stopped.
     deprecated:
         since: "3.4.0"
+        removed: "9.0.0"
         notes: Use [Titanium.Android.Activity.onStop](Titanium.Android.Activity.onStop) instead.
     description: |
         See also: [onStop](https://developer.android.com/reference/android/app/Activity.html#onStop())
@@ -370,7 +386,7 @@ properties:
     summary: |
         Callback function called when the Android activity is created.
     since: "3.4.0"
-    type: Callback<Object>
+    type: Callback<ActivityLifecycleCallbackObject>
 
   - name: onCreateOptionsMenu
     summary: |
@@ -382,19 +398,19 @@ properties:
          See also: 
          [Creating an Options Menu](https://developer.android.com/guide/topics/ui/menus.html#options-menu) 
          in the Android Developer's Guide.
-    type: Callback<Object>
+    type: Callback<OptionsMenuCallbackObject>
 
   - name: onDestroy
     summary: |
         Callback function called when the Android activity is destroyed.
     since: "3.4.0"
-    type: Callback<Object>
+    type: Callback<ActivityLifecycleCallbackObject>
 
   - name: onPause
     summary: |
         Callback function called when the Android activity is paused.
     since: "3.4.0"
-    type: Callback<Object>
+    type: Callback<ActivityLifecycleCallbackObject>
 
   - name: onPrepareOptionsMenu
     summary:  |
@@ -406,31 +422,31 @@ properties:
          See also: 
          [Creating an Options Menu](https://developer.android.com/guide/topics/ui/menus.html#options-menu) 
          in the Android Developer's Guide.
-    type: Callback<Object>
+    type: Callback<OptionsMenuCallbackObject>
 
   - name: onRestart
     summary: |
         Callback function called when the Android activity is restarted.
     since: "3.4.0"
-    type: Callback<Object>
+    type: Callback<ActivityLifecycleCallbackObject>
 
   - name: onResume
     summary: |
         Callback function called when the Android activity is resumed.
     since: "3.4.0"
-    type: Callback<Object>
+    type: Callback<ActivityLifecycleCallbackObject>
 
   - name: onStart
     summary: |
         Callback function called when the Android activity is started.
     since: "3.4.0"
-    type: Callback<Object>
+    type: Callback<ActivityLifecycleCallbackObject>
 
   - name: onStop
     summary: |
         Callback function called when the Android activity is stopped.
     since: "3.4.0"
-    type: Callback<Object>
+    type: Callback<ActivityLifecycleCallbackObject>
 
   - name: requestedOrientation
     summary: Specifies a specific orientation for this activity.
@@ -444,7 +460,7 @@ properties:
          This property is used to set a toolbar as an ActionBar prior to the actual activity creation.
          After the activity is created that must be done through the [setSupportActionBar()](Titanium.Android.Activity.setSupportActionBar) method.
     type: Titanium.UI.Toolbar
-    since: 6.2.0
+    since: "6.2.0"
 
 examples:
   - title: Callback Example
@@ -488,3 +504,26 @@ properties:
         the intent as "extras").
     type: Titanium.Android.Intent
 
+---
+name: ActivityLifecycleCallbackObject
+summary: |
+    Simple object passed to the <Titanium.Android.Activity> callbacks for
+    onCreate, onDestroy, onPause, onResume, onStart, onStop, onRestart.
+
+    Additional properties may be set on the Object.
+properties:
+  - name: source
+    summary: The Activity firing the callback.
+    type: Titanium.Android.Activity
+
+---
+name: OptionsMenuCallbackObject
+summary: |
+    Simple object passed to the <Titanium.Android.Activity> callbacks for
+    onPrepareOptionsMenu and onCreateOptionsMenu.
+
+    Additional properties may be set on the Object.
+properties:
+  - name: menu
+    summary: The relevant Menu.
+    type: Titanium.Android.Menu

apidoc/Titanium/Calendar/Calendar.yml

@@ -69,6 +69,7 @@ methods:
   - name: requestEventsAuthorization
     deprecated:
         since: "5.1.0"
+        removed: "8.1.0"
         notes: Use [Titanium.Calendar.requestCalendarPermissions](Titanium.Calendar.requestCalendarPermissions) instead.
     summary: If authorization is unknown, the system will bring up a dialog requesting permission.
     description: |
@@ -327,7 +328,7 @@ properties:
 
   - name: AUTHORIZATION_AUTHORIZED
     summary: |
-        An [eventsAuthorization](Titanium.Calendar.eventsAuthorization) value
+        An [calendarAuthorization](Titanium.Calendar.calendarAuthorization) value
         indicating that the application is authorized to use events in the Calendar.
     description: |
         This value is always returned if the device is running an iOS release prior to 6.0.
@@ -337,15 +338,15 @@ properties:
 
   - name: AUTHORIZATION_DENIED
     summary: |
-        An [eventsAuthorization](Titanium.Calendar.eventsAuthorization) value
+        An [calendarAuthorization](Titanium.Calendar.calendarAuthorization) value
         indicating that the application is not authorized to use events in the Calendar.
     type: Number
     permission: read-only
     platforms: [iphone, ipad]
 
   - name: AUTHORIZATION_RESTRICTED
     summary: |
-        An [eventsAuthorization](Titanium.Calendar.eventsAuthorization) value
+        An [calendarAuthorization](Titanium.Calendar.calendarAuthorization) value
         indicating that the application is not authorized to use events in the Calendar.
         the user cannot change this application's status.
     type: Number
@@ -354,7 +355,7 @@ properties:
 
   - name: AUTHORIZATION_UNKNOWN
     summary: |
-        An [eventsAuthorization](Titanium.Calendar.eventsAuthorization) value
+        An [calendarAuthorization](Titanium.Calendar.calendarAuthorization) value
         indicating that the authorization state is unknown.
     type: Number
     permission: read-only
@@ -729,6 +730,7 @@ properties:
          Always returns `AUTHORIZATION_AUTHORIZED` on iOS pre-6.0.
     deprecated:
         since: "5.2.0"
+        removed: "8.1.0"
         notes: Use [Titanium.Calendar.calendarAuthorization](Titanium.Calendar.calendarAuthorization) instead.
     type: Number
     constants: Titanium.Calendar.AUTHORIZATION_*