Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): firebase upload issue with "ti.map" and "ti.playservices" #11467

Merged
merged 4 commits into from Feb 11, 2020
Merged

fix(android): firebase upload issue with "ti.map" and "ti.playservices" #11467

merged 4 commits into from Feb 11, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Feb 7, 2020 •
edited

JIRA:
https://jira.appcelerator.org/browse/TIMOB-27746

Summary:

  • Update modules "ti.playservices" and "ti.map" to have valid "AndroidManifest.xml" file.
    • Build system was wrongly injecting XML "android" namespace declarations to child tags.
  • Fixes issue where Firebase "App Distrubtion" would not accept APKs containing these modules.

Test:

  1. Build kitchensink-v2 for Android.
  2. Upload APK to "App Distribution" in Firebase console website.
  3. Verify that it uploads without error.

@jquick-axway
fix(android): firebase upload with ti.map and ti.playservices
978abe9 
- Updated modules to have valid "AndroidManifest.xml" that Firebase "App Distribution" will accept when uploading APK.
@jquick-axway jquick-axway added this to the 9.0.0 milestone Feb 7, 2020
@build
Copy link
Contributor

build commented Feb 7, 2020 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6550 tests are passing.
(There are 701 skipped tests not included in that total)

Generated by 🚫 dangerJS against 7f1f052

garymathews
garymathews approved these changes Feb 8, 2020
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lokeshchdhry
Copy link
Contributor

FR Passed.

KSV2 apk was successfully uploaded to firebase app distribution.

Studio Ver: 6.0.0.201911251516
SDK Ver: local build
OS Ver: 10.14.5
Xcode Ver: Xcode 11.3.1
Appc NPM: 4.2.15
Appc CLI: 7.1.2
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.2
Alloy Ver: 1.14.4
Node Ver: 12.13.1
NPM Ver: 6.12.1
Java Ver: 11.0.1

@ssjsamir ssjsamir merged commit f63e597 into tidev:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jquick-axway @build @lokeshchdhry @garymathews @ssjsamir