Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android)(9_0_X): module build should add empty "build.gradle" if missing #11484

Merged
merged 2 commits into from Mar 2, 2020
Merged

feat(android)(9_0_X): module build should add empty "build.gradle" if missing #11484

merged 2 commits into from Mar 2, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway added this to the 9.0.0 milestone Feb 19, 2020
@build
Copy link
Contributor

build commented Feb 19, 2020 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 458 skipped out of 4946 total tests.

Tests:

ClassnameNameTimeError
ios.iphone.Titanium.UI.TableViewDelete row (Search Active) (13.2.2)5.519
Error: timeout of 5000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/33553906-8E65-496F-9960-5AA28BE72DC7/data/Containers/Bundle/Application/66B62D00-5683-4598-9E46-67E2D3E6134D/mocha.app/ti-mocha.js:6535:53732

Generated by 🚫 dangerJS against 46813e7

garymathews
garymathews approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

An empty build.gradle file is added to the module & its not overwritten.

Studio Ver: 6.0.0.201911251516
SDK Ver: 9.0.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 11.3.1
Appc NPM: 5.0.0-2
Appc CLI: 8.0.0-master.9
Daemon Ver: 3.2.0
Ti CLI Ver: 5.2.2
Alloy Ver: 1.14.5
Node Ver: 12.13.1
NPM Ver: 6.12.1
Java Ver: 11.0.1
Emulator: Android 10

@sgtcoolguy sgtcoolguy merged commit e863e49 into tidev:9_0_X Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android improvement in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jquick-axway @build @lokeshchdhry @garymathews @sgtcoolguy