Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): module build should add empty "build.gradle" if missing #11483

Merged
merged 3 commits into from
Mar 2, 2020

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-27770

Summary:
When building module with Titanium 9.0.0 and higher, module template's empty "build.gradle" file should be copied to project if missing. Reasons...

  • Compel devs to use it for library dependencies when migrating module to 9.0.0.
  • Appcelerator Studio needs a "clue" to identify folder as an Android project to resolve TISTUD-9204. Will fail to build/package module without it.

Test:

  1. Download a zip of ti.imagefactory.
  2. Unzip the module.
  3. Open the "Terminal" and CD to: ./ti.imagefactory/android
  4. Notice that there is no build.gradle file in this directory. (This is okay for now.)
  5. In Terminal, enter: appc run -p android
  6. Verify module builds and example project runs in emulator successfully.
  7. Verify a build.gradle file was add to directory ./ti.imagefactory/android.
  8. Open build.gradle file and add a code comment such as: // This is a test.
  9. In Terminal, enter: appc run -p android --build-only
  10. Open build.gradle file and verify comment is still there. (ie: Verify file was not overwritten.)

@build
Copy link
Contributor

build commented Feb 19, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 703 skipped out of 7258 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Android.ServicecreateService-background-interval (9)10.008
Error: timeout of 10000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53120)
android.emulator.Titanium.Android.ServicestartService-background-interval (9)16.849
Error: timeout of 10000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53120)

Generated by 🚫 dangerJS against ececb9a

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

An empty build.gradle file is added to the module & its not overwritten.

Studio Ver: 6.0.0.201911251516
SDK Ver: 9.1.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 11.3.1
Appc NPM: 5.0.0-2
Appc CLI: 8.0.0-master.9
Daemon Ver: 3.2.0
Ti CLI Ver: 5.2.2
Alloy Ver: 1.14.5
Node Ver: 12.13.1
NPM Ver: 6.12.1
Java Ver: 11.0.1
Emulator: Android 10

@sgtcoolguy sgtcoolguy merged commit 6e066e0 into tidev:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants