Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android)(9_0_X): build should auto-download NDK if not installed #11532

Merged
merged 3 commits into from Mar 20, 2020
Merged

feat(android)(9_0_X): build should auto-download NDK if not installed #11532

merged 3 commits into from Mar 20, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway added this to the 9.0.1 milestone Mar 11, 2020
@build
Copy link
Contributor

build commented Mar 11, 2020 •
edited

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6555 tests are passing.
(There are 703 skipped tests not included in that total)

Generated by 🚫 dangerJS against 1c42297

@ssaddique
Copy link
Contributor

ssaddique commented Mar 19, 2020 •
edited

FR Passed

NDK auto installs if it isn't already installed. Verified with the test case listed on this PR

@ssaddique ssaddique merged commit 6c1a206 into tidev:9_0_X Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android improvement in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquick-axway @build @ssaddique @garymathews