Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): build should auto-download NDK if not installed #11531

Merged
merged 6 commits into from
Mar 20, 2020

Conversation

jquick-axway
Copy link
Contributor

JIRA:

Summary:
Gradle supports auto-downloading the Android NDK if not installed. This PR leverages this feature when building the Titanium SDK or a module. Once downloaded/installed, gradle will re-use it. This will help reduce tech-support issues.

Module Test:

  1. Use a machine that does not have the NDK installed.
  2. Download the zipped source of module ti.imagefactory.
  3. Open the Terminal.
  4. CD to directory: ./ti.imagefactory/android
  5. Enter: appc run -p android
  6. Verify that you see log message similar to the below. This may take a few minutes.
    [INFO] [GRADLE] Preparing "Install NDK (revision: 21.0.6113669)"
  7. Verify that the module builds and its example project runs.

@build
Copy link
Contributor

build commented Mar 11, 2020

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6626 tests are passing.
(There are 699 skipped tests not included in that total)

Generated by 🚫 dangerJS against 67cbef7

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS 👍

@ssaddique
Copy link
Contributor

FR Passed

NDK auto installs if it isn't already installed. Verified with the test case listed on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants