Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): module build to download ndk with gradle tool 3.5.0+ #11613

Merged
merged 3 commits into from Apr 30, 2020

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-27798

Note:
The PR for TIMOB-27755 must be merged first. Otherwise, Titanium's build tools will fail to find the downloaded NDK under the side-by-side directory which will break Titanium app builds.

Summary:

  • After updating Android gradle tool from 3.4.2 to 3.6.0, module builds no longer auto-downloads NDK if missing.
  • Issue is on Google's end which default to an "unstable" NDK version and tool does not support downloading unstable versions.

Test:
Follow the the test procedure written in PR #11531.

- After updating Android gradle tool from 3.4.x to 3.6.0, module builds no longer auto-downloads NDK if missing.
- Issue on Google's end which default to an "unstable" NDK version and tool does not support downloading unstable versions.
@build
Copy link
Contributor

build commented Apr 10, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 709 skipped out of 7345 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.UI.WebViewprogress event (13.2.2)0.791
Error: expected 'https://www.google.com/#spf=1588219418548' to be equals one of Array [ 'https://www.google.com/', 'https://www.google.com' ]
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/F77CB658-56A6-4456-8790-32B676E15B36/data/Containers/Bundle/Application/FFF7DD91-FC1B-4FCE-81A7-E0E34E8F3B4E/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/F77CB658-56A6-4456-8790-32B676E15B36/data/Containers/Bundle/Application/FFF7DD91-FC1B-4FCE-81A7-E0E34E8F3B4E/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/F77CB658-56A6-4456-8790-32B676E15B36/data/Containers/Bundle/Application/FFF7DD91-FC1B-4FCE-81A7-E0E34E8F3B4E/mocha.app/ti.ui.webview.test.js:733:28

Generated by 🚫 dangerJS against 1d7168c

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@garymathews
Copy link
Contributor

garymathews commented Apr 13, 2020

NOTE FOR QE: Although the code changes are good, the fallback NDK 21.0.6113669 will exhibit Bad file descriptor. This is okay, and will be addressed in 9.1.0.

@jquick-axway
Copy link
Contributor Author

@garymathews, I think I should set the NDK version 1 release back to avoid that.

- Downgraded default NDK version for modules from 21.0.6113669 to 20.1.5948944
  * Avoids harmless "bad file descriptor" errors that get logged by newest NDK.
@ssekhri
Copy link

ssekhri commented Apr 30, 2020

FR Passed.

  1. With no NDK on the system, the module build installs side-by-side NDK
  2. When side-by-side NDK (any other version) is already installed the module build does not install the NDK
  3. When side-by-side NDK is not installed but another NDK is on the system. "appc ti config" does not have flag for android.ndkPath set then the build for module installs side-by-side NDK.
  4. When side-by-side NDK is not installed but another NDK is on the system. "appc ti config" flag for android.ndkPath is set to the NDK on the system then the module build does not install side-by-side NDK.

Verified on:
Mac OS: 10.15.4
SDK: 9.1.0.v20200413165732
Appc CLI: 8.0.0
JDK: 13.0.2
Node: 10.17.0

@sgtcoolguy sgtcoolguy merged commit c32658a into tidev:master Apr 30, 2020
@build build mentioned this pull request May 15, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants