New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): module build to download ndk with gradle tool 3.5.0+ #11613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- After updating Android gradle tool from 3.4.x to 3.6.0, module builds no longer auto-downloads NDK if missing. - Issue on Google's end which default to an "unstable" NDK version and tool does not support downloading unstable versions.
Tests:
|
garymathews
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
NOTE FOR QE: Although the code changes are good, the fallback NDK
|
@garymathews, I think I should set the NDK version 1 release back to avoid that. |
- Downgraded default NDK version for modules from 21.0.6113669 to 20.1.5948944 * Avoids harmless "bad file descriptor" errors that get logged by newest NDK.
FR Passed.
Verified on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://jira.appcelerator.org/browse/TIMOB-27798
Note:
The PR for TIMOB-27755 must be merged first. Otherwise, Titanium's build tools will fail to find the downloaded NDK under the side-by-side directory which will break Titanium app builds.
Summary:
Test:
Follow the the test procedure written in PR #11531.