Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): app/module builds fail with JDK 14 #11636

Merged
merged 9 commits into from Apr 29, 2020

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-27850

Summary:

  • Updated gradle wrapper/library from 6.2.1 to 6.3.0.
    • The newest version supports JDK 14.
  • Updated Android gradle tool from 3.6.0 to 3.6.2.

Note to QE:
On Mac, you can have multiple JDKs installed. After installing JDK 14 and running the below tests, you can select the older installed JDK by doing the following at the command line.

List the JDK versions installed on Mac.

/usr/libexec/java_home -V

Select the JDK version to use. You should set this in your .bash_profile file. Replace below <JavaVersion> with what was listed above.

export JAVA_HOME=$(/usr/libexec/java_home -v <JavaVersion>)

App Build Test:

  1. Set up a machine with JDK 14. (Reboot if you just installed it.)
  2. Build kitchensink-v2 for Android.
  3. Verify it builds and runs on Android without issue.

Module Build Test:

  1. Set up a machine with JDK 14. (Reboot if you just installed it.)
  2. Download a zip of the ti.imagefactory source.
  3. Open the Terminal.
  4. CD to directory: ./ti.imagefactory/android
  5. Enter: appc run -p android
  6. Verify module builds and its example project runs in the emulator.

@build
Copy link
Contributor

build commented Apr 16, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 3 tests have failed There are 3 tests failing and 709 skipped out of 7346 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Androidactivity callbacks (9)5.009
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53120)
ios.ipad.Titanium.UI.NavigationWindow#popToRootWindow() (13.2.2)10.002
Error: timeout of 10000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/480970E5-608F-4ABF-9DFE-32A4D2DCE2C8/data/Containers/Bundle/Application/24BBCFAF-BD4D-4DA9-99B8-57D7BD3E25E1/mocha.app/ti-mocha.js:6535:53732
ios.ipad.Titanium.UI.WebViewprogress event (13.2.2)1.155
Error: expected 'https://www.google.com/#spf=1588173552794' to be equals one of Array [ 'https://www.google.com/', 'https://www.google.com' ]
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/480970E5-608F-4ABF-9DFE-32A4D2DCE2C8/data/Containers/Bundle/Application/24BBCFAF-BD4D-4DA9-99B8-57D7BD3E25E1/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/480970E5-608F-4ABF-9DFE-32A4D2DCE2C8/data/Containers/Bundle/Application/24BBCFAF-BD4D-4DA9-99B8-57D7BD3E25E1/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/480970E5-608F-4ABF-9DFE-32A4D2DCE2C8/data/Containers/Bundle/Application/24BBCFAF-BD4D-4DA9-99B8-57D7BD3E25E1/mocha.app/ti.ui.webview.test.js:733:28

Generated by 🚫 dangerJS against 88e375b

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jquick-axway
Copy link
Contributor Author

I should change the downloaded file from gradle-6.3-bin.zip to gradle-6.3-all.zip. It's about 50 MB bigger, but it allows the Android Studio editor to support intellisense/tab-completion for gradle APIs.

@ssekhri
Copy link

ssekhri commented Apr 27, 2020

FR Passed. App and module builds fine with different java versions(11,13,14)
Verified on:
Mac OS: 10.15.4
SDK: 9.1.0.v20200417083201
Appc CLI: 8.0.0
JDK: 11.0.6, 13.0.2, 14.0.1
Node: 10.17.0
Studio: 6.0.0.202003181504
Device: Pixel3(v10.0) emulator

@sgtcoolguy sgtcoolguy merged commit 787c204 into tidev:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants