New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): hide/show progress dialog back-to-back puts it in bad state as if 8.1.1 #11684
Conversation
…tate - Regression was introduced as of Titanium 8.1.1.
|
Can this be a 9.0.2 candidate as it seems to be a regression? We may run into this as well. |
@hansemannn, the team doesn't want to add anymore tickets to 9.0.2 unless it's a show-stopper issue, because we plan on doing a release soon. But you shouldn't be running into this issue unless you do exactly this... const window = Ti.UI.createWindow();
const progressIndicator = Ti.UI.Android.createProgressIndicator({
message: "Loading...",
location: Ti.UI.Android.PROGRESS_INDICATOR_DIALOG,
cancelable: true,
});
window.addEventListener("open", () => {
progressIndicator.show();
setTimeout(() => {
// Calling hide/show back-to-back causes next hide() to not work.
progressIndicator.hide();
progressIndicator.show();
}, 1000);
});
window.open(); |
Yep, thats exactly what we do - showing concurring loaders. But with different instances. Does it not happen then? Then we're fine! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
FR Passed. Verified on: |
JIRA:
https://jira.appcelerator.org/browse/TIMOB-27573
Summary:
Calling progress dialog's
hide()
and then immediatelyshow()
back-to-back prevents the dialog from ever being hidden again. Caused by the JavaonDismiss()
listener for previous dialog being invoked just aftershow()
method call for the new dialog.Test 1:
(Verifies the above ticket's fix.)
Test 2:
(Verifies progress dialog can be re-shown after auto-closed.)