Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(9_0_X): hide/show progress dialog back-to-back puts it in bad state as if 8.1.1 #11746

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

jquick-axway
Copy link
Contributor

…tate

- Regression was introduced as of Titanium 8.1.1.
@build
Copy link
Contributor

build commented Jun 2, 2020

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️

Commit d250080654d2ea1b400479c13d23a476d7c7ddab has a message "fix(android): hide/show progress dialog back-to-back puts it in bad state

  • Regression was introduced as of Titanium 8.1.1." giving 1 errors:
  • header must not be longer than 72 characters, current length is 73
Messages
📖

💾 Here's the generated SDK zipfile.

📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

📖 ❌ 4 tests have failed There are 4 tests failing and 696 skipped out of 7287 total tests.

Tests:

ClassnameNameTimeError
android.emulator.TitaniumbuildDate (9)0.001
Error: expected '6/2/2020 21:04' to match /[01]?\d\/[0123]\d\/20\d{2} \d{2}:\d{2}/
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value [as match] (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.test.js:32:22)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
android.emulator.Titanium.Database#executeAllAsync() handles being closed mid-query (9)30.039
Error: timeout of 30000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53120)
ios.ipad.TitaniumbuildDate (13.4.1)0.001
Error: expected '6/2/2020 21:04' to match /[01]?\d\/[0123]\d\/20\d{2} \d{2}:\d{2}/
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/99FA48FD-7AEF-45AF-9BFE-73CD41F5F29C/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/99FA48FD-7AEF-45AF-9BFE-73CD41F5F29C/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/99FA48FD-7AEF-45AF-9BFE-73CD41F5F29C/mocha.app/ti.test.js:32:27
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/99FA48FD-7AEF-45AF-9BFE-73CD41F5F29C/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/99FA48FD-7AEF-45AF-9BFE-73CD41F5F29C/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/99FA48FD-7AEF-45AF-9BFE-73CD41F5F29C/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/99FA48FD-7AEF-45AF-9BFE-73CD41F5F29C/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/99FA48FD-7AEF-45AF-9BFE-73CD41F5F29C/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/99FA48FD-7AEF-45AF-9BFE-73CD41F5F29C/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/99FA48FD-7AEF-45AF-9BFE-73CD41F5F29C/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/DEE5F328-6E70-40FE-B6E9-3A854EE8DACB/data/Containers/Bundle/Application/99FA48FD-7AEF-45AF-9BFE-73CD41F5F29C/mocha.app/ti-mocha.js:5764:23
ios.iphone.TitaniumbuildDate (13.4.1)0
Error: expected '6/2/2020 21:04' to match /[01]?\d\/[0123]\d\/20\d{2} \d{2}:\d{2}/
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/36C508D6-07C5-4C86-81B6-BB4CC8E0B201/data/Containers/Bundle/Application/886F9A1D-0A6D-4D11-A392-4E0219373E84/mocha.app/node_modules/should/cjs/should.js:275:19
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/36C508D6-07C5-4C86-81B6-BB4CC8E0B201/data/Containers/Bundle/Application/886F9A1D-0A6D-4D11-A392-4E0219373E84/mocha.app/node_modules/should/cjs/should.js:356:13
file:///Users/build/Library/Developer/CoreSimulator/Devices/36C508D6-07C5-4C86-81B6-BB4CC8E0B201/data/Containers/Bundle/Application/886F9A1D-0A6D-4D11-A392-4E0219373E84/mocha.app/ti.test.js:32:27
file:///Users/build/Library/Developer/CoreSimulator/Devices/36C508D6-07C5-4C86-81B6-BB4CC8E0B201/data/Containers/Bundle/Application/886F9A1D-0A6D-4D11-A392-4E0219373E84/mocha.app/ti-mocha.js:6535:54167
file:///Users/build/Library/Developer/CoreSimulator/Devices/36C508D6-07C5-4C86-81B6-BB4CC8E0B201/data/Containers/Bundle/Application/886F9A1D-0A6D-4D11-A392-4E0219373E84/mocha.app/ti-mocha.js:6535:58607
file:///Users/build/Library/Developer/CoreSimulator/Devices/36C508D6-07C5-4C86-81B6-BB4CC8E0B201/data/Containers/Bundle/Application/886F9A1D-0A6D-4D11-A392-4E0219373E84/mocha.app/ti-mocha.js:6535:59452
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/36C508D6-07C5-4C86-81B6-BB4CC8E0B201/data/Containers/Bundle/Application/886F9A1D-0A6D-4D11-A392-4E0219373E84/mocha.app/ti-mocha.js:6535:58015
file:///Users/build/Library/Developer/CoreSimulator/Devices/36C508D6-07C5-4C86-81B6-BB4CC8E0B201/data/Containers/Bundle/Application/886F9A1D-0A6D-4D11-A392-4E0219373E84/mocha.app/ti-mocha.js:6535:57979
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/36C508D6-07C5-4C86-81B6-BB4CC8E0B201/data/Containers/Bundle/Application/886F9A1D-0A6D-4D11-A392-4E0219373E84/mocha.app/ti-mocha.js:6535:57667
file:///Users/build/Library/Developer/CoreSimulator/Devices/36C508D6-07C5-4C86-81B6-BB4CC8E0B201/data/Containers/Bundle/Application/886F9A1D-0A6D-4D11-A392-4E0219373E84/mocha.app/ti-mocha.js:6535:57763
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/36C508D6-07C5-4C86-81B6-BB4CC8E0B201/data/Containers/Bundle/Application/886F9A1D-0A6D-4D11-A392-4E0219373E84/mocha.app/ti-mocha.js:5764:23

Generated by 🚫 dangerJS against d250080

@sgtcoolguy sgtcoolguy merged commit 4e4b509 into tidev:9_0_X Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants