Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios) : build issue for XCode < 11 #11711

Merged
merged 5 commits into from May 21, 2020
Merged

fix(ios) : build issue for XCode < 11 #11711

merged 5 commits into from May 21, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway
fix(ios) : build issue for XCode < 11
35b5a9f
@vijaysingh-axway
Revert "fix(ios) : build issue for XCode < 11"
6ffebd2 
This reverts commit 35b5a9f.
@vijaysingh-axway
Merge branch 'master' of https://github.com/appcelerator/titanium_mobile
2b617c3 


# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@vijaysingh-axway
Merge branch 'master' of https://github.com/appcelerator/titanium_mobile
1222856
@vijaysingh-axway
fix(ios) : build issue for XCode < 11
afcb3f4
@build build added this to the 9.1.0 milestone May 18, 2020
@build build requested review from a team May 18, 2020 20:44
@build build added the docs label May 18, 2020
@build
Copy link
Contributor

build commented May 18, 2020 •
edited

Warnings
⚠️

Commit 35b5a9f7ff1dcfa7cfd8a48cb69b44c43cdbfedf has a message "fix(ios) : build issue for XCode < 11" giving 2 errors:

  • subject may not be empty
  • type may not be empty
⚠️

Commit afcb3f48f408c3b097e4580c4fcc167a00b9ed44 has a message "fix(ios) : build issue for XCode < 11" giving 2 errors:

  • subject may not be empty
  • type may not be empty
Messages
📖

💾 Here's the generated SDK zipfile.
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖

✅ All tests are passing
Nice one! All 6649 tests are passing.
(There are 709 skipped tests not included in that total)

Generated by 🚫 dangerJS against afcb3f4

sgtcoolguy
sgtcoolguy approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgtcoolguy sgtcoolguy merged commit 52d4d81 into tidev:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
bug docs ios no tests
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vijaysingh-axway @build @sgtcoolguy