New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android): auto-download NDK r21c for module builds if needed #11755
Conversation
- This NDK version was notarized for macOS Catalina. Prevents security popups when doing module builds.
|
- Compiling with Android NDK 21 and higher would cause several harmless "Bad file descriptor" errors to be logged. - Caused by NDK 21 setting "--output-sync" argument default. Setting it to "none" restores old behavior.
- Using NDK command line argument --output-sync will cause a build failure on NDK 19 and lower. And we don't need to pass it into NDK 20.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed: No longer see Bad file descriptor
errors and able to install NDK if no other NDKs are found.
Test Environment
MacOS Catalina: 10.15.5 Beta
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0","CLI":"8.0.0""
Andoird Pixl xl 7.1.1 Emulator
JIRA:
Summary:
Module Test:
CD
to directory:./ti.imagefactory/android
appc run -p android
[INFO] [GRADLE] Preparing "Install NDK (revision: 21.2.6472646)"