Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(android): auto-download NDK r21c for module builds if needed #11755

Merged
merged 5 commits into from
Jun 9, 2020
Merged

chore(android): auto-download NDK r21c for module builds if needed #11755

merged 5 commits into from
Jun 9, 2020

Commits on Jun 5, 2020

  1. chore(android): auto-download NDK r21c for module builds 

    - This NDK version was notarized for macOS Catalina. Prevents security popups when doing module builds.
    @jquick-axway
    jquick-axway committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    f54aa89 View commit details
    Browse the repository at this point in the history

  2. fix(android): bad file descriptor errors with NDK v21 builds 

    - Compiling with Android NDK 21 and higher would cause several harmless "Bad file descriptor" errors to be logged.
- Caused by NDK 21 setting "--output-sync" argument default. Setting it to "none" restores old behavior.
    @jquick-axway
    jquick-axway committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    60fba0b View commit details
    Browse the repository at this point in the history

  3. fix(android): only use --output-sync for NDK 21+ 

    - Using NDK command line argument --output-sync will cause a build failure on NDK 19 and lower. And we don't need to pass it into NDK 20.
    @jquick-axway
    jquick-axway committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    a64d8d4 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. chore(android): removed TIMOB-27939 commented-out code

    @jquick-axway
    jquick-axway committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    dc652b4 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Merge branch 'master' into TIMOB-27939

    @garymathews
    garymathews committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    5ecb06b View commit details
    Browse the repository at this point in the history