chore(android): update gradle tools and dependencies #11819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated to gradle from 6.3.0 to 6.5.1 - Updated Android gradle tool from 3.6.2 to 4.0.0 * Can no longer use Android Studio version older than 4.0 - Updated kotlin gradle plugin from 1.3.61 to 1.3.72 - Updated AndroidX dependencies to newest versions
Tests:
|
sgtcoolguy
reviewed
Jul 14, 2020
| @@ -28,10 +28,10 @@ | |||
| "compileSDKVersion": "29", | |||
| "vendorDependencies": { | |||
| "android sdk": ">=23.x <=29.x", | |||
| "android build tools": ">=28.0.3 <=29.x", | |||
| "android build tools": ">=29.0.2 <=29.x", | |||
There was a problem hiding this comment.
feels like a bit of an odd version range to use here...
There was a problem hiding this comment.
To clarify, Android gradle tool v4.0.0 requires SDK build tool v29.0.2 or higher.
https://developer.android.com/studio/releases/gradle-plugin?buildsystem=ndk-build#4-0-0
There isn't a release version of SDK build tools v30.0.0 yet. It's currently an RC version.
https://developer.android.com/studio/releases/build-tools#notes
Also, we don't use these build tools directly anymore. Our Titanium SDK build scripts do pretty much everything via gradle (except for adb which is okay). But I'm trying to keep up with the version ranges here just in case something else depends on them that I'm not aware of.
(Note that gradle will automatically download/install these tools for us now.)
There was a problem hiding this comment.
Or would you prefer we "uncap" the build tools version and not set a max?
I think that might be okay.
garymathews
reviewed
Jul 16, 2020
- Updated Java checkstyle to 8.34 Fixes TIMOB-27938
garymathews
approved these changes
Jul 17, 2020
ssjsamir
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
FR Passed:
Able to build the apps mentioned in the test steps above using the updated gradle tools and dependencies.
Test Environment
MacOS Big Sur: 11.0 Beta
Xcode: 12.0 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.0.0""
API30 Pixel XL emulator
android23-x86 emulator (nexus 5x)
|
Ticket verified on build 9.1.0.v20200804082025. I can confirm everything builds as normal. Test environment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://jira.appcelerator.org/browse/TIMOB-27938
Summary:
6.3.0to 6.5.1.3.6.2to 4.0.1.1.3.61to 1.3.72.KitchenSink Test:
Hyperloop Test:
Module Test:
CDto the./ti.imagefactory/androidfolder.appc run -p android