fix(ios): use xcodeTargetOS of 'iphoneos' for mac catalyst #12118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related to tidev/hyperloop.next#342 and #12112
Instead of fixing it in a hack way in the hyperloop code, this fixe step underlying issue int he SDK itself. Hyperloop relies on using the builder's
xcodeTargetOS
value to refer to sdks in Xcode related tooling. When we set it to'maccatalyst'
that breaks. So we retain a value of'iphoneos'
instead and just update the couple places in the SDK CLI where it was used to generate folder names to use a different variable.I tested the following
app.js
with these changes viati build -p ios -T macos
(and the hyperloop module from #12112):