Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: silence aca load failure #12227

Merged
merged 2 commits into from Oct 28, 2020
Merged

Conversation

garymathews
Copy link
Contributor

  • Silence ACA module load failure rejection
TEST
  1. Remove ACA module from tiapp.xml
  2. Launch app
  3. Observe no ACA module load failure error messages

JIRA Ticket

} catch (e) {
// Could not load module, silently ignore exception.
}
import('com.appcelerator.aca').catch(e => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ common/Resources/ti.internal/aca.js line 11 – 'e' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

@build
Copy link
Contributor

build commented Oct 28, 2020

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 11678 tests are passing.
(There are 978 skipped tests not included in that total)

Generated by 🚫 dangerJS against 6964a6a

@ssekhri
Copy link

ssekhri commented Oct 28, 2020

FR Passed.
Verified on:
Mac OS: 10.15.4
SDK: 9.3.0.v20201027173842
Appc CLI: 8.1.1
JDK: 11.0.4
Node: 10.17.0
Studio: 6.0.0.202005141803
Xcode: 12.0.1
iPhone 7Plus(v14.0), iOS simulator v14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants