Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 9_2_X] fix: silence aca load failure #12229

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

build
Copy link
Contributor

@build build commented Oct 28, 2020

Backport of #12227.
See that PR for full details.

@sgtcoolguy sgtcoolguy merged commit f9e00fd into tidev:9_2_X Oct 28, 2020
@build build added this to the 9.2.2 milestone Oct 28, 2020
} catch (e) {
// Could not load module, silently ignore exception.
}
import('com.appcelerator.aca').catch(e => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ common/Resources/ti.internal/aca.js line 11 – 'e' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

@build
Copy link
Contributor Author

build commented Oct 28, 2020

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 7244 tests are passing.
(There are 713 skipped tests not included in that total)

Generated by 🚫 dangerJS against fc19373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants