Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): update "ti.playservice" module to 17.5.0 #12246

Merged
merged 3 commits into from Nov 4, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Nov 4, 2020

JIRA:
https://jira.appcelerator.org/browse/TIMOB-27934

Summary:

  • Updated Google Play Services library from 17.1.1 to 17.5.0.
  • Changed makeGooglePlayServicesAvailable() method to use native implementation.
    • Now shows Google's standard dialog if Play Services needs to be updated.
    • Couldn't use native implementation before because backing out of the activity that was hosting this dialog used to crash on Google's end. Google has now fixed it.
  • Updated to support upcoming "run-in-background" feature in the future. See: TIMOB-27896

Test:

  1. Open the Android emulator.
  2. Go to: Settings -> Apps -> Google Play Services
  3. Tap on the "Disable" button.
  4. Build and run kitchen-sink-v2.
  5. On app startup, verify a dialog appears asking you to enable Google Play Services.
  6. Tap on the dialog's okay button.
  7. Tap on the "Back" button. (Do NOT tap on the dialog's okay button.)
  8. Verify you are exited out of the app.
  9. Re-launch the app.
  10. On app startup, this time tap on the dialog's okay button.
  11. Verify that you are taken to the Google Play Services "App Info" screen.
  12. Do not enable it. Instead, tap on the "Back" button.
  13. Verify you are exited out of the app.
  14. Re-launch the app.
  15. Tap on the dialog's okay button.
  16. Tap on the "Enable" button in the Google Play Services window.
  17. Tap on the "Back" button.
  18. Verify the kitchen sink app now launches.
  19. Back out of the app.
  20. Re-launch the app.
  21. Verify the Google Play Services dialog does NOT appear and you are taken directly to the app.

@build
Copy link
Contributor

build commented Nov 4, 2020

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 12045 tests are passing.
(There are 966 skipped tests not included in that total)

Generated by 🚫 dangerJS against 9d8bc93

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a simple CR viewpoint, these changes look good to me.

@ssekhri
Copy link

ssekhri commented Nov 4, 2020

FR Passed

Verified on:
Mac OS: 10.15.4
SDK: 9.3.0.v20201103180838
Appc CLI: 8.1.1
JDK: 11.0.6
Node: 12.16.1
Studio: 6.0.0.202005141803
Device: Pixel 3 XL(v11.0) emulator

@sgtcoolguy sgtcoolguy merged commit c60ae72 into tidev:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants