feat(android): use cameraX #12395

m1ga · 2021-01-18T11:57:16Z

JIRA: https://jira-archive.titaniumsdk.com/AC-6676
Fixes #13525

Optional Description:

Will use CameraX on Android when using a camera with an overlay

const win = Ti.UI.createWindow({layout: "vertical", backgroundColor: "#fff"});

const buttons = [
	"open camera (old camera)",
	"open camera",
	"open camera (no autoHide)",
	"open camera (flash on)",
	"open camera (flash auto)",
	"open camera (video)",
	"open camera (video, low bit rate)",
	"open camera (video, low resolution)",
	"open camera (video, max duration)",
	"open camera (small output image)",
];
const results = Ti.UI.createView({height: Ti.UI.SIZE, width: Ti.UI.FILL, layout: "horizontal"});
const img = Ti.UI.createImageView({width: "45%", height: Ti.UI.SIZE, autorotate: true});
const videoPlayer = Titanium.Media.createVideoPlayer({height: 200, width: "45%", mediaControlStyle: Titanium.Media.VIDEO_CONTROL_DEFAULT, scalingMode: Titanium.Media.VIDEO_SCALING_RESIZE_ASPECT});
var isRecording = false;
var videoMaximumDuration = 0;
var isBack = true;

results.add([img, videoPlayer])

for (var i = 0; i < buttons.length; ++i) {
	var btn = Ti.UI.createButton({title: buttons[i], idx: i + 1, height: 40, borderRadius:0, width: 300});
	btn.addEventListener("click", openCamera);
	win.add(btn);
}
win.add(results);

var cameraSizes = Ti.Media.cameraOutputSizes;
if (cameraSizes != null) {
	for (var i=0; i<cameraSizes.length;++i){
		console.log(cameraSizes[i].cameraType);
		console.log(cameraSizes[i].values);
	}
}


function openCamera(e) {
	var sourceId = e.source.idx;
	var isVideo = (sourceId == "6" || sourceId == "7" || sourceId == "8" || sourceId == "9");
	var overlay = Ti.UI.createView({height: Ti.UI.FILL, height: Ti.UI.FILL});
	var isTorch = isFlash = isZoom = false;
	var btnText = (isVideo) ? "Record video" : "Take picture";
	var useCameraX = (sourceId != "1");
	var btn = Ti.UI.createButton({title: btnText, bottom: 10});
	var btn2 = Ti.UI.createButton({title: "Switch cam", bottom: 50});
	var btn3 = Ti.UI.createButton({title: "torch", bottom: 90, left: 10});
	var btn4 = Ti.UI.createButton({title: "flash (off)", bottom: 90, right: 10});
	var btn5 = Ti.UI.createButton({title: "zoom", bottom: 90});
	overlay.add([btn, btn2, btn3, btn4,btn5]);

	btn.addEventListener("click", function() {
		if (isVideo) {
			if (!isRecording) {
				Ti.Media.startVideoCapture()
				isRecording = true;
				btn.title = "Stop";
			} else {
				Ti.Media.stopVideoCapture()
				isRecording = false;
				btn.title = btnText;
			}
		} else {
			Ti.Media.takePicture()
		}
	})
	btn2.addEventListener("click", function() {
		if (isBack) {
			Ti.Media.switchCamera(Titanium.Media.CAMERA_FRONT)
		} else {
			Ti.Media.switchCamera(Titanium.Media.CAMERA_REAR)
		}
		isBack = !isBack;
	})
	btn3.addEventListener("click", function() {
		isTorch = !isTorch;
		Ti.Media.torch = isTorch;
	})
	btn4.addEventListener("click", function() {
		if (isFlash) {
			Ti.Media.cameraFlashMode = Titanium.Media.CAMERA_FLASH_OFF
			btn4.title = "flash (off)";
		} else {
			Ti.Media.cameraFlashMode = Titanium.Media.CAMERA_FLASH_ON
			btn4.title = "flash (on)";
		}
		isFlash = !isFlash;
	})
	btn5.addEventListener("click", function() {
		if (isZoom) {
			Ti.Media.zoomLevel = 1;
		} else {
			Ti.Media.zoomLevel = Ti.Media.maxZoomLevel - 0.5;
		}
		isZoom = !isZoom;
	})

	var flashMode = Titanium.Media.CAMERA_FLASH_OFF;
	if (sourceId == "4") {
		isFlash = true;
		flashMode = Titanium.Media.CAMERA_FLASH_ON;
		btn4.title = "flash (on)";
	} else if (sourceId == "5") {
		flashMode = Titanium.Media.CAMERA_FLASH_AUTO;
	}

	var autohide = true;
	if (sourceId == "3") {
		autohide = false;
	}

	var mediaType = Titanium.Media.MEDIA_TYPE_IMAGE;
	if (sourceId == "6") {
		mediaType = Titanium.Media.MEDIA_TYPE_VIDEO;
	}

	var bitRate = -1;
	var frameRate = -1;
	if (sourceId == "7") {
		mediaType = Titanium.Media.MEDIA_TYPE_VIDEO;
		bitRate = 120;
		frameRate = 2 * 1024 * 1024;
	}

	var maxResolution = null;
	if (sourceId == "8") {
		mediaType = Titanium.Media.MEDIA_TYPE_VIDEO;
		maxResolution = {
			width: 300,
			height: 200
		}
	}

	if (sourceId == "9") {
		mediaType = Titanium.Media.MEDIA_TYPE_VIDEO;
		videoMaximumDuration = 2000;
	}

	var imgWidth = -1;
	var imgHeight = -1;
	if (sourceId == "10") {
		// lower the target image resolution
		imgWidth = 240;
		imgHeight = 320;
	}

	btn2.visible = btn3.visible = btn4.visible = btn5.visible = useCameraX;

	Ti.Media.requestCameraPermissions(function(e) {
		if (e.success) {
			Ti.Media.showCamera({
				autohide: autohide,
				useCameraX: useCameraX,
				cameraFlashMode: flashMode,
				overlay: overlay,
				frameRate: frameRate,
				bitRate: bitRate,
				mediaTypes: [mediaType],
				saveToPhotoGallery: true,
				maxResolution: maxResolution,
				videoMaximumDuration: videoMaximumDuration,
				targetImageWidth: imgWidth,
				targetImageHeight: imgHeight,
				success: function(e) {

					if (e.mediaType == "public.movie") {
						var f = Ti.Filesystem.getFile(Ti.Filesystem.applicationDataDirectory, "tmp.mp4");
						f.write(e.media);
						videoPlayer.url = f.nativePath;
						videoPlayer.play();
					} else {
						img.image = e.media;
					}
					console.log("type", e.mediaType);
					console.log("size", e.media.size);
					console.log("width", e.media.width, "height", e.media.height);
				}
			});
		}
	});
}

win.open();

Features:

Tested:

Pixel 4, Android 13
Pixel 7, Android 13
Samsung A20, Android 11

Ti.Media.showCamera({
	success: onCameraSuccess,
	overlay: view_overlay,
	aspectRatio: Ti.Media.ASPECT_RATIO_16_9,
	scalingMode: Ti.Media.IMAGE_SCALING_ASPECT_FIT,
	open: function(e) {
		console.log(e);
	}
});

16:9 image with ASPECT_FILL

16:9 image with ASPECT_FIT

build · 2021-01-18T13:55:57Z

	Fails
🚫	Test reports missing for Android 5.0, Android Main, CLI, iPad, iPhone, MacOS. This indicates that a build failed or the test app crashed
🚫	🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

	Warnings
⚠️	Commit 05cc839edb945fb0ce0b46b1e31ce177f882841f has a message "merge" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit 3502f498dbec6625d28474b29edae95267694c59 has a message "max video duration" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit 2899cea19fa9a1769614ae640e690806198eba4e has a message "version update" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit 4ba122e18142fc494372db09c2ad1b9e52e8fc32 has a message "version update, permission check" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit fb833e758401cb0448f97a10c7c51eaf01296bfa has a message "update" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit 9e50759946640e9f9946559c0fbfec556f2f47cb has a message "remove old files" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit 9021cadc3265ee2240080aa792bd6709365db44e has a message "update library version" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit 3427c8e92c51b760dd67b6fab0b0fa8126d5d6ab has a message "bit rate, max resolution, bug fixes" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit cc0e5d221f5e52ca2352d31be011985b4f0cedb7 has a message "change video camera" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit be9b5eaee6003cca90c342b30db31395ca3c109b has a message "video start" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit cdea992513877c121a659ad06fcdf59c8a3f1a46 has a message "save image" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit ba2d6380b1c9d23f4cd97c39c2d18f8e0b8d2278 has a message "flash" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit e0f549500527c738fe267abde5ab593cbee49070 has a message "android back, switch lens" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit 89a9a5e6ed3481eb5e0b22bea43a51670e5637b0 has a message "close camera" giving 2 errors: subject may not be empty type may not be empty
⚠️	Commit 79e21969e43798d674122447a8491d0bd3525544 has a message "camerax overlay" giving 2 errors: subject may not be empty type may not be empty
⚠️	🔍 Can't find junit reports at `./junit.*.xml`, skipping generating JUnit Report.
⚠️	This PR has milestone set to 10.0.0, but the version defined in package.json is 10.2.0 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch

	Messages
📖	🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖	🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍
📖	👍 Hey!, You deleted more code than you added. That's awesome!

Generated by 🚫 dangerJS against cfe1f05

into cameraX

…o cameraX

m1ga · 2022-10-08T10:03:57Z

added Ti.Media.torch = true/false to switch on the light when the camera is open. That will light up the whole time and not like the flash only when you take the image

m1ga · 2022-11-25T12:50:06Z

Added output image parameters:

var cameraSizes = Ti.Media.cameraOutputSizes;
for (var i=0; i<cameraSizes.length;++i){
	console.log(cameraSizes[i].cameraType);
	console.log(cameraSizes[i].values);
}

to get the potential sizes.

And you can set them with:

targetImageWidth: 800,
targetImageHeight: 600,

m1ga · 2023-03-19T15:30:39Z

some new additions that makes working with overlays a lot easier:

open callback that contains the size of the preview (e.g. if you use 4:3 it will be wider than your screen)
aspectRatio with two constants Ti.Media.ASPECT_RATIO_16_9 and Ti.Media.ASPECT_RATIO_4_3
scalingMode with Ti.Media.IMAGE_SCALING_ASPECT_FIT and Ti.Media.IMAGE_SCALING_ASPECT_FILL

having the preview only be FIT (full width) makes it easier to work with overlays:

m1ga · 2023-03-19T15:38:38Z

verticalAlign with Ti.Media.VERTICAL_ALIGN_BOTTOM (top, bottom, center)

m1ga · 2023-05-01T16:02:37Z

added the old files back. The new cameraX part is used when you set useCameraX: true opening the camera.
That way we can merge this quicker as the default is still the old way and you can opt-in to the new way

hansemannn · 2023-05-01T17:56:01Z

Let's take this in and give it some testing during the next 1-2 releases. If it runs smooth, we can make it default after that 🙏

hansemannn

Some more feedback - mostly questions to be sure! One general thing: As the code is pretty separated now, wouldn't it make sense to wrap it up inside a module to be able to quickly iterate on it, then include it to the SDK once stable? We did the same with ti.wkwebview back then.

android/titanium/build.gradle

apidoc/Titanium/Media/Media.yml

hansemannn · 2023-05-03T19:50:57Z

apidoc/Titanium/Media/Media.yml

+    platforms: [android]
+    since: "12.1.0"
+
+  - name: VERTICAL_ALIGN_TOP


Prefix this constants to be more distinctive regarding other ones?

hansemannn · 2023-05-03T20:02:18Z

android/modules/media/src/java/ti/modules/titanium/media/TiCameraXActivity.java

+			} else if (videoRecordEvent instanceof VideoRecordEvent.Pause) {
+				// Handle the case where the active recording is paused
+			} else if (videoRecordEvent instanceof VideoRecordEvent.Resume) {
+				// Handles the case where the active recording is resumed


More events useful?

android/modules/media/src/java/ti/modules/titanium/media/TiCameraXActivity.java

hansemannn · 2023-05-03T20:06:33Z

android/modules/media/src/java/ti/modules/titanium/media/TiCameraXActivity.java

+		}
+		if (camera != null) {
+			camera = null;
+		}


Any more strong references, e.g. callbackContext and overlayProxy? It would be good to run the profiler for any memory leaks.

Good point. I'll check that. The current TiCameraActivity doesn't do more so if that works fine it will be the same in TiCameraXActivity.

m1ga · 2023-05-03T20:44:19Z

Thanks for the feedback! Already adjusted most of it!

to wrap it up inside a module to be able to quickly iterate on it, then include it to the SDK once stable? We did the same with ti.wkwebview back then.

I did so much work here already that I don't want to rip it out and create a module. I think more people test it if we just say "enable useCameraX" and don't have to add a module. It would be different too (no Ti.Media... namespace) so people would need to change code after it's merged into the SDK.

My idea would be:
have people test it in the RC/beta phase to see that it is working as a replacement (using the current features, just with the flag enabled) and then we know it is working without a difference.

If the new features have to be changed it will be in a minor bugfix release as they are "new features" that won't break existing apps. There wasn't any demand for those features so they aren't time critical (and they are Android only).

hansemannn · 2023-05-03T20:49:30Z

Totally fine! Let's merge it and await the feedback!

hansemannn

Amazing work, really excited to use this in production apps soon!

m1ga · 2023-05-03T20:51:27Z

awesome! Thanks!

* camerax overlay * close camera * android back, switch lens * flash * save image * video start * change video camera * bit rate, max resolution, bug fixes * update library version * remove old files * version update, permission check * version update * max video duration * update video part * get video from gallery, add recording callback * image: save to gallery * error msg, clean up recordings * cleanup * pinch to zoom * revert Android studio styling * docs: remove empty description * update camerax version * update * min/maxZoomLevel, zoomLevel * final version * update * move try/catch * torch, set flash mode * remove duplicated code * read camera sizes and be able to set them * raise cameraX library * aspectRatio, open callback, scalingMode * verticalAlign * add old camera files again * better defaults * minor update to camerax version * update files

m1ga added 3 commits January 16, 2021 20:54

camerax overlay

79e2196

close camera

89a9a5e

android back, switch lens

e0f5495

build added this to the 10.0.0 milestone Jan 18, 2021

build requested a review from a team January 18, 2021 13:55

build added android community 🔥 needs jira 🚨 needs tests 🚨 labels Jan 18, 2021

m1ga and others added 5 commits January 18, 2021 16:04

Merge branch 'master' into cameraX

0d5c02f

flash

ba2d638

Merge branch 'master' of https://github.com/appcelerator/titanium_mobile

2348aa6

into cameraX

Merge branch 'cameraX' of https://github.com/m1ga/titanium_mobile int…

291ae8d

…o cameraX

save image

cdea992

sgtcoolguy added the work in progress 🚧 label Feb 1, 2021

m1ga and others added 4 commits February 5, 2021 16:08

video start

be9b5ea

change video camera

cc0e5d2

Merge branch 'master' into cameraX

769c53f

bit rate, max resolution, bug fixes

3427c8e

build requested a review from a team February 8, 2021 10:38

build added the docs label Feb 8, 2021

m1ga added 2 commits February 8, 2021 12:01

update library version

9021cad

remove old files

9e50759

build removed the needs jira 🚨 label Feb 8, 2021

m1ga added 2 commits April 24, 2021 18:03

update

fb833e7

version update, permission check

4ba122e

build requested a review from a team April 26, 2021 17:10

build added ios and removed needs tests 🚨 labels Apr 26, 2021

m1ga and others added 4 commits October 8, 2022 11:06

move try/catch

2d36a0b

Merge branch 'master' into cameraX

42fdce1

Merge branch 'cameraX' of https://github.com/m1ga/titanium_mobile int…

995f47b

…o cameraX

torch, set flash mode

d4e9ffe

m1ga added 2 commits October 21, 2022 21:57

remove duplicated code

964df56

read camera sizes and be able to set them

0380525

m1ga added 4 commits January 28, 2023 20:01

Merge branch 'master' into cameraX

de56635

raise cameraX library

b3df19e

Merge branch 'master' into cameraX

8d51eda

aspectRatio, open callback, scalingMode

4e0ab47

verticalAlign

ef38cf5

m1ga added 3 commits May 1, 2023 17:28

add old camera files again

3aad6f2

Merge branch 'master' into cameraX

f69d891

better defaults

679e89d

minor update to camerax version

fad1b0f

hansemannn requested changes May 3, 2023

View reviewed changes

update files

94532ee

hansemannn approved these changes May 3, 2023

View reviewed changes

hansemannn merged commit e68d33a into tidev:master May 3, 2023
6 checks passed

m1ga deleted the cameraX branch May 3, 2023 20:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(android): use cameraX #12395

feat(android): use cameraX #12395

m1ga commented Jan 18, 2021 •

edited

build commented Jan 18, 2021 •

edited

m1ga commented Oct 8, 2022

m1ga commented Nov 25, 2022

m1ga commented Mar 19, 2023

m1ga commented Mar 19, 2023

m1ga commented May 1, 2023

hansemannn commented May 1, 2023

hansemannn left a comment •

edited

hansemannn May 3, 2023

hansemannn May 3, 2023

hansemannn May 3, 2023

m1ga May 3, 2023

m1ga commented May 3, 2023

hansemannn commented May 3, 2023

hansemannn left a comment

m1ga commented May 3, 2023

feat(android): use cameraX #12395

feat(android): use cameraX #12395

Conversation

m1ga commented Jan 18, 2021 • edited

build commented Jan 18, 2021 • edited

m1ga commented Oct 8, 2022

m1ga commented Nov 25, 2022

m1ga commented Mar 19, 2023

m1ga commented Mar 19, 2023

m1ga commented May 1, 2023

hansemannn commented May 1, 2023

hansemannn left a comment • edited

Choose a reason for hiding this comment

hansemannn May 3, 2023

Choose a reason for hiding this comment

hansemannn May 3, 2023

Choose a reason for hiding this comment

hansemannn May 3, 2023

Choose a reason for hiding this comment

m1ga May 3, 2023

Choose a reason for hiding this comment

m1ga commented May 3, 2023

hansemannn commented May 3, 2023

hansemannn left a comment

Choose a reason for hiding this comment

m1ga commented May 3, 2023

m1ga commented Jan 18, 2021 •

edited

build commented Jan 18, 2021 •

edited

hansemannn left a comment •

edited