Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: set minimum node version to 12.13.0 #12454

Merged
merged 5 commits into from Feb 9, 2021

Conversation

ewanharris
Copy link
Collaborator

@build build added this to the 10.0.0 milestone Feb 9, 2021
@build
Copy link
Contributor

build commented Feb 9, 2021

Fails
🚫 Tests have failed, see below for more information.
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 4 tests have failed There are 4 tests failing and 684 skipped out of 11625 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.View"after all" hook (5.0.2)20.431
Error: timeout of 10000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.View"after each" hook (5.0.2)10.396
Error: timeout of 10000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
ios.macos.Titanium.Blobimage dimensions should be reported in pixels (10.15.7)0.129
Error: expected 6 to be 11
value@file:///node_modules/should/cjs/should.js:356:23
postlayout@file:///ti.blob.test.js:483:33
ios.macos.Titanium.UI.WebViewbeforeload (10.15.7)30.007
Error: timeout of 30000ms exceeded
file:///ti-mocha.js:4326:27

Generated by 🚫 dangerJS against d5a5d84

@sgtcoolguy sgtcoolguy merged commit 83a1449 into tidev:master Feb 9, 2021
@ewanharris ewanharris deleted the TIMOB-28343 branch August 31, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants