Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declare i18n function before its usage #12455

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

ewanharris
Copy link
Collaborator

9_3_X backport for the CLI fix contained in #12454

@build build added this to the 9.3.2 milestone Feb 9, 2021
@build
Copy link
Contributor

build commented Feb 9, 2021

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 4 tests have failed There are 4 tests failing and 659 skipped out of 10706 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.4)1.094
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped_540x960@2x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:5764:29
ios.ipad.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4)0.353
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped_540x960@2x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/C0ED9BB2-9CF4-4EFF-9ABC-6A763BB54398/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.4)1.565
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped_540x960@3x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4)0.548
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped_540x960@3x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/E84EAB7C-FD40-457B-9D37-01E3329D0A19/data/Containers/Bundle/Application/BEEDAD92-A594-410F-A732-2C20E9CF76C5/mocha.app/ti-mocha.js:5764:29

Generated by 🚫 dangerJS against 1af0f45

@sgtcoolguy sgtcoolguy merged commit e4bc8a9 into tidev:9_3_X Feb 9, 2021
@ewanharris ewanharris deleted the fix_variable_usage branch August 31, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants