Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): removing eventListener in location event will freeze app #12542

Merged
merged 3 commits into from Mar 23, 2021
Merged

fix(ios): removing eventListener in location event will freeze app #12542

merged 3 commits into from Mar 23, 2021

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway commented Mar 11, 2021 •
edited

https://jira.appcelerator.org/browse/TIMOB-28275
Note - No Unit test. User interaction required.

@build build added this to the 10.1.0 milestone Mar 11, 2021
@build build requested a review from a team March 11, 2021 01:15
@build
Copy link
Contributor

build commented Mar 11, 2021 •
edited

Fails
🚫 Tests have failed, see below for more information.
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.
Warnings
⚠️ This PR has milestone set to 10.0.0, but the version defined in package.json is 10.1.0 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 513 skipped out of 8255 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.NavigationWindowbasic open/close navigation (5.0.2)10.098
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against 931bd8a

@vijaysingh-axway vijaysingh-axway added no tests backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge and removed needs tests 🚨 labels Mar 11, 2021
@vijaysingh-axway vijaysingh-axway modified the milestones: 10.1.0, 10.0.0 Mar 18, 2021
@ssekhri
Copy link

ssekhri commented Mar 19, 2021

FR Passed
Mac OS: 10.15.4
SDK: 10.1.0.v20210311124008
Appc CLI: 8.1.1
JDK: 11.0.6
Node: 12.16.1
Studio: 6.0.0.202005141803
Xcode: 12.3
Device: iPhone X(v13.6.1)

@sgtcoolguy sgtcoolguy merged commit c13e600 into tidev:master Mar 23, 2021
@build build mentioned this pull request Mar 23, 2021
Merged
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Mar 23, 2021
@build build mentioned this pull request Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vijaysingh-axway @build @ssekhri @sgtcoolguy