Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 9_3_X] fix(ios): removing eventListener in location event will freeze app #12646

Merged
merged 1 commit into from Mar 23, 2021

Conversation

build
Copy link
Contributor

@build build commented Mar 23, 2021

Backport of #12542.
See that PR for full details.

@build
Copy link
Contributor Author

build commented Mar 23, 2021

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 ❌ 5 tests have failed There are 5 tests failing and 679 skipped out of 9291 total tests.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.4)1.126
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped@2x~ipad.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:5764:29
ios.ipad.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4)0.385
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped@2x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/0DD61560-8F52-437B-B036-14EF1E1E14ED/data/Containers/Bundle/Application/7BFA99CA-392E-4CBD-9228-46FD02D5885B/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.4)1.412
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped@3x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4)0.437
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped@3x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/F020DE95-1F5D-4D70-9B7C-36E25B7760CE/data/Containers/Bundle/Application/1E27F930-71E7-4494-BCC2-23D6FFB400C9/mocha.app/ti-mocha.js:5764:29
ios.macos.Titanium.UI.Semantic Colorsuse semantic colors via color properties (10.15.7)0.013
Error: expected 'Ti.UI.View' to match image ('snapshots/systemredcolor_light.png')
    expected 12 to be 6
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12646/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12646/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12646/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.ui.test.js:363:34

Generated by 🚫 dangerJS against 74e92bc

@sgtcoolguy sgtcoolguy merged commit fdfe4fc into tidev:9_3_X Mar 23, 2021
@sgtcoolguy sgtcoolguy deleted the backport-12542-to-9_3_X branch March 23, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants