Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB 2906 Stop fullscreen translucent theme for modal activities. #126

Merged
merged 3 commits into from Jun 20, 2011
Merged

TIMOB 2906 Stop fullscreen translucent theme for modal activities. #126

merged 3 commits into from Jun 20, 2011

Conversation

billdawson
Copy link
Contributor

Stop fullscreen translucent theme for modal activities. Respect other flags (fullscreen, navBarHidden) when modal flag also used. Update docs to indicate that modal:true and fullscreen:true won't work together in Android. TIMOB-2906

… flags (fullscreen, navBarHidden) when modal flag also used. Update docs to indicate that modal:true and fullscreen:true won't work together in Android. TIMOB-2906
@billdawson
Copy link
Contributor Author

Testers can pay attention both to the failcase in the jira item and these KS tests: UI - Window (Standalone) - Traditional Modal (make sure the "vibrate button" is fully visible), and Mashup - Facebook - Query (make sure the top most status entry has its user name visible above it.)

@donthorp
Copy link
Contributor

Functional tested, code reviewed. Accepted.

@Thomasappcel
Copy link
Contributor

nexus s, nexus 1, galaxy tab, droid 1 using samples in bug record. Ran ks examples on tab.

@donthorp
Copy link
Contributor

Additional testing showed one issue. If modal is present as an option, we always use the modal class.
https://github.com/appcelerator/titanium_mobile/blob/master/android/modules/ui/src/ti/modules/titanium/ui/TiUIWindow.java#L539

Adding new test case to ticket.

…he time if "modal" proxy property was set, even if it was set to "false". TIMOB-2906
@billdawson
Copy link
Contributor Author

Ready for re-test after correction of situation don detected above

@donthorp
Copy link
Contributor

Retested, accepted.

donthorp added a commit that referenced this pull request Jun 20, 2011
TIMOB 2906 Stop fullscreen translucent theme for modal activities.
@donthorp donthorp merged commit 494275b into tidev:master Jun 20, 2011
@jtoth55
Copy link

jtoth55 commented Jun 21, 2011

Would you maybe want to merge this into the 1.7 branch too? Having modal windows not working correctly in Android is a fairly significant bug.

@billdawson
Copy link
Contributor Author

it is slated for 1.7 branch. you can check that via the "labels" field in the jira item. in this case we included "merge-1.7.2". 1.7 branch is currently frozen probably for a few days, but it'll be in there soon.

Harutyun referenced this pull request in Harutyun/titanium_mobile Aug 10, 2012
TIMOB-10270: BlackBerry: Implement getWidth, getHeight in UI View
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants