New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIMOB 2906 Stop fullscreen translucent theme for modal activities. #126
Conversation
… flags (fullscreen, navBarHidden) when modal flag also used. Update docs to indicate that modal:true and fullscreen:true won't work together in Android. TIMOB-2906
Testers can pay attention both to the failcase in the jira item and these KS tests: UI - Window (Standalone) - Traditional Modal (make sure the "vibrate button" is fully visible), and Mashup - Facebook - Query (make sure the top most status entry has its user name visible above it.) |
Functional tested, code reviewed. Accepted. |
nexus s, nexus 1, galaxy tab, droid 1 using samples in bug record. Ran ks examples on tab. |
Additional testing showed one issue. If modal is present as an option, we always use the modal class. Adding new test case to ticket. |
…he time if "modal" proxy property was set, even if it was set to "false". TIMOB-2906
Ready for re-test after correction of situation don detected above |
Retested, accepted. |
TIMOB 2906 Stop fullscreen translucent theme for modal activities.
Would you maybe want to merge this into the 1.7 branch too? Having modal windows not working correctly in Android is a fairly significant bug. |
it is slated for 1.7 branch. you can check that via the "labels" field in the jira item. in this case we included "merge-1.7.2". 1.7 branch is currently frozen probably for a few days, but it'll be in there soon. |
TIMOB-10270: BlackBerry: Implement getWidth, getHeight in UI View
Stop fullscreen translucent theme for modal activities. Respect other flags (fullscreen, navBarHidden) when modal flag also used. Update docs to indicate that modal:true and fullscreen:true won't work together in Android. TIMOB-2906