Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: fix eslint warnings #12603

Merged
merged 3 commits into from
Mar 17, 2021
Merged

style: fix eslint warnings #12603

merged 3 commits into from
Mar 17, 2021

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Mar 17, 2021 •
edited
Loading

Summary:
Fixes JavaScript eslint warnings reported by github action.

Notes:

  • Added Promise finally support to .eslintrc.
  • The exec() warnings were false positives. Linter wrongly interpreted RegExp.exec() calls as child_process.exec() calls. This linter warning does not appear in VS Code.

@jquick-axway jquick-axway added this to the 10.1.0 milestone Mar 17, 2021
@build
Copy link
Contributor

build commented Mar 17, 2021 •
edited
Loading

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖

✅ All tests are passing
Nice one! All 8546 tests are passing.
(There are 461 skipped tests not included in that total)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 8f09e4d

@jquick-axway jquick-axway added backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge and removed no tests labels Mar 17, 2021
sgtcoolguy
sgtcoolguy approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgtcoolguy
Copy link
Contributor

For reference the conventional commit prefix would likely be better as style: fix eslint warnings or maybe refactor: fix eslint warnings (since this is not actually a bug fix commit, but a style change).

@jquick-axway jquick-axway changed the title fix: eslint warnings style: fix eslint warnings Mar 17, 2021
@sgtcoolguy sgtcoolguy merged commit 1964e37 into tidev:master Mar 17, 2021
@build build mentioned this pull request Mar 17, 2021
Merged
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jquick-axway @build @sgtcoolguy